Re: [PATCH bpf-next v2] selftests/bpf: convert test_xdp_features.sh to test_progs

2024-10-03 Thread Alexis Lothoré
On 10/4/24 06:44, Martin KaFai Lau wrote: > On 9/24/24 6:37 PM, Martin KaFai Lau wrote: >> There are other .sh tests that could better use the test_progs migration. In >> particular the ones without existing test coverage. For non XDP related, >> test_tcp_check_syncookie.sh, test_flow_dissector.sh,

Re: [PATCH bpf-next v2] selftests/bpf: convert test_xdp_features.sh to test_progs

2024-10-03 Thread Martin KaFai Lau
On 9/24/24 6:37 PM, Martin KaFai Lau wrote: There are other .sh tests that could better use the test_progs migration. In particular the ones without existing test coverage. For non XDP related, test_tcp_check_syncookie.sh, test_flow_dissector.sh, and test_tc_edt.sh should be the good ones. I

Re: [PATCH bpf-next v2] selftests/bpf: convert test_xdp_features.sh to test_progs

2024-09-26 Thread Alexis Lothoré
Hi Martin, On 9/25/24 22:01, Martin KaFai Lau wrote: > On 9/25/24 3:37 AM, Martin KaFai Lau wrote: >> I am not sure which case in xdp_features.c does not have existing coverage in >> test_progs. From a quick look, it seems only BPF_MAP_TYPE_CPUMAP is missing >> (please check)? > > Re: CPUMAP, I n

Re: [PATCH bpf-next v2] selftests/bpf: convert test_xdp_features.sh to test_progs

2024-09-25 Thread Martin KaFai Lau
On 9/25/24 3:37 AM, Martin KaFai Lau wrote: I am not sure which case in xdp_features.c does not have existing coverage in test_progs. From a quick look, it seems only BPF_MAP_TYPE_CPUMAP is missing (please check)? Re: CPUMAP, I noticed there is a xdp_(cpu)map_attach.c test but it only does at

Re: [PATCH bpf-next v2] selftests/bpf: convert test_xdp_features.sh to test_progs

2024-09-24 Thread Martin KaFai Lau
On 9/22/24 12:04 PM, Alexis Lothoré wrote: Hello all, sorry for the slow feedback, I have been off last week. On 9/14/24 15:38, Jakub Kicinski wrote: On Sat, 14 Sep 2024 11:25:47 +0200 Lorenzo Bianconi wrote: On Sep 13, Martin KaFai Lau wrote: test a physical network device that supports a ce

Re: [PATCH bpf-next v2] selftests/bpf: convert test_xdp_features.sh to test_progs

2024-09-22 Thread Alexis Lothoré
Hello all, sorry for the slow feedback, I have been off last week. On 9/14/24 15:38, Jakub Kicinski wrote: > On Sat, 14 Sep 2024 11:25:47 +0200 Lorenzo Bianconi wrote: >> On Sep 13, Martin KaFai Lau wrote: >>> test a physical network device that supports a certain XDP features. >>> >>> iiuc, test_

Re: [PATCH bpf-next v2] selftests/bpf: convert test_xdp_features.sh to test_progs

2024-09-14 Thread Jakub Kicinski
On Sat, 14 Sep 2024 11:25:47 +0200 Lorenzo Bianconi wrote: > On Sep 13, Martin KaFai Lau wrote: > > test a physical network device that supports a certain XDP features. > > > > iiuc, test_xdp_features.sh only uses the veth and veth will also be the only > > device tested after moving to prog_tests

Re: [PATCH bpf-next v2] selftests/bpf: convert test_xdp_features.sh to test_progs

2024-09-14 Thread Lorenzo Bianconi
On Sep 13, Martin KaFai Lau wrote: > On 9/10/24 11:10 AM, Alexis Lothoré (eBPF Foundation) wrote: > > test_xdp_features.sh is a shell script allowing to test that xdp features > > advertised by an interface are indeed delivered. The test works by starting > > two instance of the same program, both

Re: [PATCH bpf-next v2] selftests/bpf: convert test_xdp_features.sh to test_progs

2024-09-13 Thread Martin KaFai Lau
On 9/10/24 11:10 AM, Alexis Lothoré (eBPF Foundation) wrote: test_xdp_features.sh is a shell script allowing to test that xdp features advertised by an interface are indeed delivered. The test works by starting two instance of the same program, both attaching specific xdp programs to each side of

Re: [PATCH bpf-next v2] selftests/bpf: convert test_xdp_features.sh to test_progs

2024-09-13 Thread Simon Horman
On Thu, Sep 12, 2024 at 10:17:13PM +0200, Alexis Lothoré wrote: > Hi Simon, > > On 9/11/24 16:18, Simon Horman wrote: > > [...] > > >> diff --git a/tools/testing/selftests/bpf/prog_tests/xdp_features.c > >> b/tools/testing/selftests/bpf/prog_tests/xdp_features.c > >> new file mode 100644 > >> i

Re: [PATCH bpf-next v2] selftests/bpf: convert test_xdp_features.sh to test_progs

2024-09-12 Thread Alexis Lothoré
Hi Simon, On 9/11/24 16:18, Simon Horman wrote: [...] >> diff --git a/tools/testing/selftests/bpf/prog_tests/xdp_features.c >> b/tools/testing/selftests/bpf/prog_tests/xdp_features.c >> new file mode 100644 >> index ..bcb36a2d2767 >> --- /dev/null >> +++ b/tools/testing/selftests/bp

Re: [PATCH bpf-next v2] selftests/bpf: convert test_xdp_features.sh to test_progs

2024-09-11 Thread Simon Horman
On Tue, Sep 10, 2024 at 08:10:35PM +0200, Alexis Lothoré (eBPF Foundation) wrote: > test_xdp_features.sh is a shell script allowing to test that xdp features > advertised by an interface are indeed delivered. The test works by starting > two instance of the same program, both attaching specific xd

[PATCH bpf-next v2] selftests/bpf: convert test_xdp_features.sh to test_progs

2024-09-10 Thread eBPF Foundation
test_xdp_features.sh is a shell script allowing to test that xdp features advertised by an interface are indeed delivered. The test works by starting two instance of the same program, both attaching specific xdp programs to each side of a veth link, and then make those programs manage packets and c