Re: [PATCH RFC] block: Eliminate first argument of submit_bio()

2014-06-02 Thread Jens Axboe
On 2014-06-02 03:44, Bart Van Assche wrote: The submit_bio() API is confusing. Merge functions like raid5_mergeable_bvec() can only work correctly if bi_rw is set before bio_add_page() has been called. submit_bio() modifies bi_rw after bio_add_page() has been called. Hence remove the first argume

Re: [PATCH RFC] block: Eliminate first argument of submit_bio()

2014-06-02 Thread Christoph Hellwig
On Mon, Jun 02, 2014 at 11:44:07AM +0200, Bart Van Assche wrote: > The submit_bio() API is confusing. Merge functions like > raid5_mergeable_bvec() can only work correctly if bi_rw is set > before bio_add_page() has been called. submit_bio() modifies > bi_rw after bio_add_page() has been called. He

[PATCH RFC] block: Eliminate first argument of submit_bio()

2014-06-02 Thread Bart Van Assche
The submit_bio() API is confusing. Merge functions like raid5_mergeable_bvec() can only work correctly if bi_rw is set before bio_add_page() has been called. submit_bio() modifies bi_rw after bio_add_page() has been called. Hence remove the first argument of submit_bio() and let the caller set bi_r