On Mon, Jun 02, 2014 at 11:44:07AM +0200, Bart Van Assche wrote: > The submit_bio() API is confusing. Merge functions like > raid5_mergeable_bvec() can only work correctly if bi_rw is set > before bio_add_page() has been called. submit_bio() modifies > bi_rw after bio_add_page() has been called. Hence remove the > first argument of submit_bio() and let the caller set bi_rw. > Note: some but not all submit_bio() callers have been fixed > such that bi_rw is set before bio_add_page() is called.
I like this a lot! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/