On Mon, Dec 24, 2012 at 03:04:59PM +0900, Namhyung Kim wrote:
> Right. I also have no idea what's the best way to handle --gtk option
> with the piped output. I can think of 3 options for this:
>
> 1) exit with a error message
> 2) honor --gtk option and launch a gui browser
I could befriend #2
On Sat, Dec 22, 2012 at 12:44 AM, Borislav Petkov wrote:
> On Fri, Dec 21, 2012 at 06:16:46PM +0900, Namhyung Kim wrote:
>> Current setup_browser() code checks the stdin to be a tty and if
>> not it assumes piping to other commands so set the use_browser to 0
>> (stdio) and disables GTK output.
>>
On Fri, Dec 21, 2012 at 06:16:46PM +0900, Namhyung Kim wrote:
> Current setup_browser() code checks the stdin to be a tty and if
> not it assumes piping to other commands so set the use_browser to 0
> (stdio) and disables GTK output.
>
> Maybe we can change this behavior for --gtk case.
Change it
Hi Boris,
On Fri, 21 Dec 2012 09:32:05 +0100, Borislav Petkov wrote:
> On Fri, Dec 21, 2012 at 05:20:18PM +0900, Namhyung Kim wrote:
>> Now we have GTK2 implementation, add a new --gtk option to use it.
>>
>> Cc: Pekka Enberg
>> Signed-off-by: Namhyung Kim
>> ---
>> tools/perf/Documentation/pe
On Fri, Dec 21, 2012 at 05:20:18PM +0900, Namhyung Kim wrote:
> Now we have GTK2 implementation, add a new --gtk option to use it.
>
> Cc: Pekka Enberg
> Signed-off-by: Namhyung Kim
> ---
> tools/perf/Documentation/perf-annotate.txt | 4
> tools/perf/builtin-annotate.c | 5 +++
Now we have GTK2 implementation, add a new --gtk option to use it.
Cc: Pekka Enberg
Signed-off-by: Namhyung Kim
---
tools/perf/Documentation/perf-annotate.txt | 4
tools/perf/builtin-annotate.c | 5 -
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/tools/perf
6 matches
Mail list logo
