On Sat, Dec 22, 2012 at 12:44 AM, Borislav Petkov <b...@alien8.de> wrote: > On Fri, Dec 21, 2012 at 06:16:46PM +0900, Namhyung Kim wrote: >> Current setup_browser() code checks the stdin to be a tty and if >> not it assumes piping to other commands so set the use_browser to 0 >> (stdio) and disables GTK output. >> >> Maybe we can change this behavior for --gtk case. > > Change it in the sense that for the --gtk case stdin doesn't have to > be a tty? So that with --gtk you can still pipe perf output to other > commands? > > I can't imagine a sensible --gtk use case with output piped to other > commands. Hmm.
Right. I also have no idea what's the best way to handle --gtk option with the piped output. I can think of 3 options for this: 1) exit with a error message 2) honor --gtk option and launch a gui browser 3) honor piped output and print to stdout (thus ignore --gtk) like this patch does Any thoughts? -- Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
