RE: [PATCH 5/5] I/OAT: Add completion callback for async_tx interface use

2007-10-17 Thread Nelson, Shannon
>From: David Miller [mailto:[EMAIL PROTECTED] > >From: Andrew Morton <[EMAIL PROTECTED]> >Date: Wed, 17 Oct 2007 17:44:38 -0700 > >> On Wed, 17 Oct 2007 17:14:39 -0700 >> Shannon Nelson <[EMAIL PROTECTED]> wrote: >> >> > + tx->callback = (void *)ioat_dma_test_callback; >> >> and when I remove t

Re: [PATCH 5/5] I/OAT: Add completion callback for async_tx interface use

2007-10-17 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Wed, 17 Oct 2007 17:44:38 -0700 > On Wed, 17 Oct 2007 17:14:39 -0700 > Shannon Nelson <[EMAIL PROTECTED]> wrote: > > > + tx->callback = (void *)ioat_dma_test_callback; > > and when I remove this cast I get > > drivers/dma/ioat_dma.c: In function '

RE: [PATCH 5/5] I/OAT: Add completion callback for async_tx interface use

2007-10-17 Thread Nelson, Shannon
>From: Andrew Morton [mailto:[EMAIL PROTECTED] > >On Wed, 17 Oct 2007 17:14:39 -0700 >Shannon Nelson <[EMAIL PROTECTED]> wrote: [...] >> +static dma_async_tx_callback ioat_dma_test_callback(void >*dma_async_param) >> +{ >> +printk(KERN_ERR "ioatdma: ioat_dma_test_callback(0x%04llx)\n", >> +

Re: [PATCH 5/5] I/OAT: Add completion callback for async_tx interface use

2007-10-17 Thread Andrew Morton
On Wed, 17 Oct 2007 17:14:39 -0700 Shannon Nelson <[EMAIL PROTECTED]> wrote: > + printk(KERN_ERR "ioatdma: ioat_dma_test_callback(0x%04llx)\n", > + (u64)dma_async_param); Generates a warning on 32-bit: drivers/dma/ioat_dma.c: In function 'ioat_dma_test_callback': drivers/dma/ioat

Re: [PATCH 5/5] I/OAT: Add completion callback for async_tx interface use

2007-10-17 Thread Andrew Morton
On Wed, 17 Oct 2007 17:14:39 -0700 Shannon Nelson <[EMAIL PROTECTED]> wrote: > The async_tx interface includes a completion callback. This adds support > for using that callback, including using interrupts on completion. > > Signed-off-by: Shannon Nelson <[EMAIL PROTECTED]> > --- > > drivers/d

[PATCH 5/5] I/OAT: Add completion callback for async_tx interface use

2007-10-17 Thread Shannon Nelson
The async_tx interface includes a completion callback. This adds support for using that callback, including using interrupts on completion. Signed-off-by: Shannon Nelson <[EMAIL PROTECTED]> --- drivers/dma/ioat_dma.c | 26 ++ 1 files changed, 26 insertions(+), 0 deleti