Re: [PATCH 4.4 3/3] futex: fix dead code in attach_to_pi_owner()

2021-03-10 Thread Zhengyejian (Zetta)
On 2021/3/10 22:10, Greg KH wrote: On Wed, Mar 10, 2021 at 01:28:02PM +, Lee Jones wrote: On Wed, 10 Mar 2021, Greg KH wrote: On Tue, Mar 09, 2021 at 06:14:37PM +, Lee Jones wrote: On Tue, 09 Mar 2021, Greg KH wrote: On Tue, Mar 09, 2021 at 11:06:05AM +0800, Zheng Yejian wrote:

Re: [PATCH 4.4 3/3] futex: fix dead code in attach_to_pi_owner()

2021-03-10 Thread Greg KH
On Wed, Mar 10, 2021 at 01:28:02PM +, Lee Jones wrote: > On Wed, 10 Mar 2021, Greg KH wrote: > > > On Tue, Mar 09, 2021 at 06:14:37PM +, Lee Jones wrote: > > > On Tue, 09 Mar 2021, Greg KH wrote: > > > > > > > On Tue, Mar 09, 2021 at 11:06:05AM +0800, Zheng Yejian wrote: > > > > > From: T

Re: [PATCH 4.4 3/3] futex: fix dead code in attach_to_pi_owner()

2021-03-10 Thread Lee Jones
On Wed, 10 Mar 2021, Greg KH wrote: > On Tue, Mar 09, 2021 at 06:14:37PM +, Lee Jones wrote: > > On Tue, 09 Mar 2021, Greg KH wrote: > > > > > On Tue, Mar 09, 2021 at 11:06:05AM +0800, Zheng Yejian wrote: > > > > From: Thomas Gleixner > > > > > > > > The handle_exit_race() function is defin

Re: [PATCH 4.4 3/3] futex: fix dead code in attach_to_pi_owner()

2021-03-10 Thread Greg KH
On Tue, Mar 09, 2021 at 06:14:37PM +, Lee Jones wrote: > On Tue, 09 Mar 2021, Greg KH wrote: > > > On Tue, Mar 09, 2021 at 11:06:05AM +0800, Zheng Yejian wrote: > > > From: Thomas Gleixner > > > > > > The handle_exit_race() function is defined in commit 9c3f39860367 > > > ("futex: Cure exit

Re: [PATCH 4.4 3/3] futex: fix dead code in attach_to_pi_owner()

2021-03-09 Thread Lee Jones
On Tue, 09 Mar 2021, Greg KH wrote: > On Tue, Mar 09, 2021 at 11:06:05AM +0800, Zheng Yejian wrote: > > From: Thomas Gleixner > > > > The handle_exit_race() function is defined in commit 9c3f39860367 > > ("futex: Cure exit race"), which never returns -EBUSY. This results > > in a small piece of

Re: [PATCH 4.4 3/3] futex: fix dead code in attach_to_pi_owner()

2021-03-09 Thread Greg KH
On Tue, Mar 09, 2021 at 11:06:05AM +0800, Zheng Yejian wrote: > From: Thomas Gleixner > > The handle_exit_race() function is defined in commit 9c3f39860367 > ("futex: Cure exit race"), which never returns -EBUSY. This results > in a small piece of dead code in the attach_to_pi_owner() function:

[PATCH 4.4 3/3] futex: fix dead code in attach_to_pi_owner()

2021-03-08 Thread Zheng Yejian
From: Thomas Gleixner The handle_exit_race() function is defined in commit 9c3f39860367 ("futex: Cure exit race"), which never returns -EBUSY. This results in a small piece of dead code in the attach_to_pi_owner() function: int ret = handle_exit_race(uaddr, uval, p); /* Never return -EB