Re: [PATCH 4/9] gpiolib: use gpio_chips list in sysfs ops

2013-02-09 Thread Alexandre Courbot
On Sat, Feb 9, 2013 at 6:37 PM, Grant Likely wrote: > However, this code is incorrect (it was incorrect before you touched it, > so not your fault). Moving it to a list makes it a lot worse though > because it introduces the possibility of dereferencing an invalid > pointer. The hooks need to grab

Re: [PATCH 4/9] gpiolib: use gpio_chips list in sysfs ops

2013-02-09 Thread Grant Likely
On Tue, 5 Feb 2013 18:15:54 +0100, Linus Walleij wrote: > On Sat, Feb 2, 2013 at 5:29 PM, Alexandre Courbot wrote: > > > This makes the code both simpler and faster compared to parsing the GPIO > > number space. > > > > Signed-off-by: Alexandre Courbot > > Reviewed-by: Linus Walleij Applied

Re: [PATCH 4/9] gpiolib: use gpio_chips list in sysfs ops

2013-02-05 Thread Linus Walleij
On Sat, Feb 2, 2013 at 5:29 PM, Alexandre Courbot wrote: > This makes the code both simpler and faster compared to parsing the GPIO > number space. > > Signed-off-by: Alexandre Courbot Reviewed-by: Linus Walleij Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe

[PATCH 4/9] gpiolib: use gpio_chips list in sysfs ops

2013-02-02 Thread Alexandre Courbot
This makes the code both simpler and faster compared to parsing the GPIO number space. Signed-off-by: Alexandre Courbot --- drivers/gpio/gpiolib.c | 37 ++--- 1 file changed, 10 insertions(+), 27 deletions(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpi