On Tue, 5 Feb 2013 18:15:54 +0100, Linus Walleij <linus.wall...@linaro.org> wrote: > On Sat, Feb 2, 2013 at 5:29 PM, Alexandre Courbot <acour...@nvidia.com> wrote: > > > This makes the code both simpler and faster compared to parsing the GPIO > > number space. > > > > Signed-off-by: Alexandre Courbot <acour...@nvidia.com> > > Reviewed-by: Linus Walleij <linus.wall...@linaro.org>
Applied, thanks. However, this code is incorrect (it was incorrect before you touched it, so not your fault). Moving it to a list makes it a lot worse though because it introduces the possibility of dereferencing an invalid pointer. The hooks need to grab the spinlock before parsing the list. I've got a patch which I'll post. I'd appreciate it if you can test also. In actual fact, I'd like to replace the spinlock with a mutex, but that requires some auditing to make sure there aren't any users from an atomic context. g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
