Re: [PATCH 4/6] x86: relocs: build separate 32/64-bit tools

On 04/16/2013 03:38 PM, Kees Cook wrote: >> >> Have simple wrapper files which do: >> >> /* relocs_32.c */ >> #define ELF_BITS 32 >> #include "relocs.c" >> >> /* relocs_64.c */ >> #define ELF_BITS 64 >> #include "relocs.c" > > That's what I did in my first pass, but it seemed even worse to me. I >

Re: [PATCH 4/6] x86: relocs: build separate 32/64-bit tools

On Tue, Apr 16, 2013 at 3:21 PM, H. Peter Anvin wrote: > On 04/12/2013 01:13 PM, Kees Cook wrote: >> Since the ELF structures and access macros change size based on 32 vs >> 64 bits, build a separate 32-bit relocs tool (for handling realmode >> and 32-bit relocations), and a 64-bit relocs tool (fo

Re: [PATCH 4/6] x86: relocs: build separate 32/64-bit tools

On 04/12/2013 01:13 PM, Kees Cook wrote: > Since the ELF structures and access macros change size based on 32 vs > 64 bits, build a separate 32-bit relocs tool (for handling realmode > and 32-bit relocations), and a 64-bit relocs tool (for handling 64-bit > kernel relocations). > > Signed-off-by:

[PATCH 4/6] x86: relocs: build separate 32/64-bit tools

Since the ELF structures and access macros change size based on 32 vs 64 bits, build a separate 32-bit relocs tool (for handling realmode and 32-bit relocations), and a 64-bit relocs tool (for handling 64-bit kernel relocations). Signed-off-by: Kees Cook -- This is ugly with the "cp". Is there so