On Tue, Apr 16, 2013 at 3:21 PM, H. Peter Anvin <h...@zytor.com> wrote: > On 04/12/2013 01:13 PM, Kees Cook wrote: >> Since the ELF structures and access macros change size based on 32 vs >> 64 bits, build a separate 32-bit relocs tool (for handling realmode >> and 32-bit relocations), and a 64-bit relocs tool (for handling 64-bit >> kernel relocations). >> >> Signed-off-by: Kees Cook <keesc...@chromium.org> >> -- >> This is ugly with the "cp". Is there some other cleaner way to trigger >> two builds with different defines from the same source file? > > There definitely is. > > Have simple wrapper files which do: > > /* relocs_32.c */ > #define ELF_BITS 32 > #include "relocs.c" > > /* relocs_64.c */ > #define ELF_BITS 64 > #include "relocs.c"
That's what I did in my first pass, but it seemed even worse to me. I will go back to this. Thanks! -Kees -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
