Re: [PATCH 4/4] workqueue: slash half memory usage in 32bit system

2020-06-02 Thread Tejun Heo
Hello, On Tue, Jun 02, 2020 at 08:08:10AM +0800, Lai Jiangshan wrote: > It is not noticable from the "free" command. > By counting the number of allocated pwq (mainly percpu pwq), > it saves 20k in my simple kvm guest (4cpu). > I guess it highly various in different boxes with various > kernel mod

Re: [PATCH 4/4] workqueue: slash half memory usage in 32bit system

2020-06-01 Thread Lai Jiangshan
On Mon, Jun 1, 2020 at 11:07 PM Tejun Heo wrote: > > On Mon, Jun 01, 2020 at 08:44:42AM +, Lai Jiangshan wrote: > > The major memory ussage in workqueue is on the pool_workqueue. > > The pool_workqueue has alignment requirement which often leads > > to padding. > > > > Reducing the memory usag

Re: [PATCH 4/4] workqueue: slash half memory usage in 32bit system

2020-06-01 Thread Tejun Heo
On Mon, Jun 01, 2020 at 08:44:42AM +, Lai Jiangshan wrote: > The major memory ussage in workqueue is on the pool_workqueue. > The pool_workqueue has alignment requirement which often leads > to padding. > > Reducing the memory usage for the pool_workqueue is valuable. > > And 32bit system oft

[PATCH 4/4] workqueue: slash half memory usage in 32bit system

2020-06-01 Thread Lai Jiangshan
The major memory ussage in workqueue is on the pool_workqueue. The pool_workqueue has alignment requirement which often leads to padding. Reducing the memory usage for the pool_workqueue is valuable. And 32bit system often has less memory, less workqueues, less works, less concurrent flush_workqu