Re: [PATCH 4/4] sched: bias to target cpu load to reduce task moving

2014-01-08 Thread Alex Shi
On 01/07/2014 08:59 PM, Peter Zijlstra wrote: > On Tue, Jan 07, 2014 at 12:55:18PM +, Morten Rasmussen wrote: >> My understanding is that should_we_balance() decides which cpu is >> eligible for doing the load balancing for a given domain (and the >> domains above). That is, only one cpu in a g

Re: [PATCH 4/4] sched: bias to target cpu load to reduce task moving

2014-01-07 Thread Peter Zijlstra
On Tue, Jan 07, 2014 at 03:16:32PM +, Morten Rasmussen wrote: > From a load perspective wouldn't it be better to pick the least loaded > cpu in the group? It is not cheap to implement, but in theory it should > give less balancing within the group later an less unfairness until it > happens. I

Re: [PATCH 4/4] sched: bias to target cpu load to reduce task moving

2014-01-07 Thread Morten Rasmussen
On Tue, Jan 07, 2014 at 01:15:23PM +, Peter Zijlstra wrote: > On Tue, Jan 07, 2014 at 01:59:30PM +0100, Peter Zijlstra wrote: > > On Tue, Jan 07, 2014 at 12:55:18PM +, Morten Rasmussen wrote: > > > My understanding is that should_we_balance() decides which cpu is > > > eligible for doing th

Re: [PATCH 4/4] sched: bias to target cpu load to reduce task moving

2014-01-07 Thread Peter Zijlstra
On Tue, Jan 07, 2014 at 02:32:07PM +0100, Vincent Guittot wrote: > On 7 January 2014 14:15, Peter Zijlstra wrote: > > On Tue, Jan 07, 2014 at 01:59:30PM +0100, Peter Zijlstra wrote: > >> On Tue, Jan 07, 2014 at 12:55:18PM +, Morten Rasmussen wrote: > >> > My understanding is that should_we_bal

Re: [PATCH 4/4] sched: bias to target cpu load to reduce task moving

2014-01-07 Thread Vincent Guittot
On 7 January 2014 14:15, Peter Zijlstra wrote: > On Tue, Jan 07, 2014 at 01:59:30PM +0100, Peter Zijlstra wrote: >> On Tue, Jan 07, 2014 at 12:55:18PM +, Morten Rasmussen wrote: >> > My understanding is that should_we_balance() decides which cpu is >> > eligible for doing the load balancing fo

Re: [PATCH 4/4] sched: bias to target cpu load to reduce task moving

2014-01-07 Thread Peter Zijlstra
On Tue, Jan 07, 2014 at 01:59:30PM +0100, Peter Zijlstra wrote: > On Tue, Jan 07, 2014 at 12:55:18PM +, Morten Rasmussen wrote: > > My understanding is that should_we_balance() decides which cpu is > > eligible for doing the load balancing for a given domain (and the > > domains above). That is

Re: [PATCH 4/4] sched: bias to target cpu load to reduce task moving

2014-01-07 Thread Peter Zijlstra
On Tue, Jan 07, 2014 at 12:55:18PM +, Morten Rasmussen wrote: > My understanding is that should_we_balance() decides which cpu is > eligible for doing the load balancing for a given domain (and the > domains above). That is, only one cpu in a group is allowed to load > balance between the local

Re: [PATCH 4/4] sched: bias to target cpu load to reduce task moving

2014-01-07 Thread Morten Rasmussen
gt;>> From: Alex Shi > >>>> Date: Sat, 23 Nov 2013 23:18:09 +0800 > >>>> Subject: [PATCH 4/4] sched: bias to target cpu load to reduce task moving > >>>> > >>>> Task migration happens when target just a bit less then source cpu load.

Re: [PATCH 4/4] sched: bias to target cpu load to reduce task moving

2014-01-06 Thread Alex Shi
On 01/03/2014 12:04 AM, Morten Rasmussen wrote: > On Wed, Dec 25, 2013 at 02:58:26PM +, Alex Shi wrote: >> >>>> From 5cd67d975001edafe2ee820e0be5d86881a23bd6 Mon Sep 17 00:00:00 2001 >>>> From: Alex Shi >>>> Date: Sat, 23 Nov 2013 23:18:09 +0800 &g

Re: [PATCH 4/4] sched: bias to target cpu load to reduce task moving

2014-01-02 Thread Morten Rasmussen
On Wed, Dec 25, 2013 at 02:58:26PM +, Alex Shi wrote: > > >> From 5cd67d975001edafe2ee820e0be5d86881a23bd6 Mon Sep 17 00:00:00 2001 > >> From: Alex Shi > >> Date: Sat, 23 Nov 2013 23:18:09 +0800 > >> Subject: [PATCH 4/4] sched: bias to target cpu lo

Re: [PATCH 4/4] sched: bias to target cpu load to reduce task moving

2013-12-25 Thread Alex Shi
>> From 5cd67d975001edafe2ee820e0be5d86881a23bd6 Mon Sep 17 00:00:00 2001 >> From: Alex Shi >> Date: Sat, 23 Nov 2013 23:18:09 +0800 >> Subject: [PATCH 4/4] sched: bias to target cpu load to reduce task moving >> >> Task migration happens when target just a

Re: [PATCH 4/4] sched: bias to target cpu load to reduce task moving

2013-12-20 Thread Alex Shi
On 12/20/2013 07:19 PM, Morten Rasmussen wrote: >> @@ -4132,10 +4137,10 @@ find_idlest_group(struct sched_domain *sd, struct >> task_struct *p, int this_cpu) >> > >> >for_each_cpu(i, sched_group_cpus(group)) { >> >/* Bias balancing toward cpus of our domain */ >>

Re: [PATCH 4/4] sched: bias to target cpu load to reduce task moving

2013-12-20 Thread Morten Rasmussen
. Any testing are appreciated! > > BTW, Seems lots of changes in scheduler come from kinds of > scenarios/benchmarks > experience. But I still like to take any theoretical comments/suggestions. > > -- > Thanks > Alex > > === > > From 5cd67d975001edafe2ee82

Re: [PATCH 4/4] sched: bias to target cpu load to reduce task moving

2013-12-19 Thread Alex Shi
comments/suggestions. -- Thanks Alex === >From 5cd67d975001edafe2ee820e0be5d86881a23bd6 Mon Sep 17 00:00:00 2001 From: Alex Shi Date: Sat, 23 Nov 2013 23:18:09 +0800 Subject: [PATCH 4/4] sched: bias to target cpu load to reduce task moving Task migration happens when target just

Re: [PATCH 4/4] sched: bias to target cpu load to reduce task moving

2013-12-17 Thread Peter Zijlstra
On Tue, Dec 17, 2013 at 02:10:12PM +, Morten Rasmussen wrote: > > @@ -4135,7 +4141,7 @@ find_idlest_group(struct sched_domain *sd, struct > > task_struct *p, int this_cpu) > > if (local_group) > > load = source_load(i); > > el

Re: [PATCH 4/4] sched: bias to target cpu load to reduce task moving

2013-12-17 Thread Morten Rasmussen
On Tue, Dec 03, 2013 at 09:05:56AM +, Alex Shi wrote: > Task migration happens when target just a bit less then source cpu load. > To reduce such situation happens, aggravate the target cpu load with > sd->imbalance_pct/100. > > This patch removes the hackbench thread regression on Daniel's >

Re: [PATCH 4/4] sched: bias to target cpu load to reduce task moving

2013-12-04 Thread Alex Shi
> We obsevered 150% performance gain with vm-scalability/300s-mmap-pread-seq > testcase with this patch applied. Here is a list of changes we got so far: > > testbox : brickland got some explain of brickland on wiki: High-end server platform based on the Ivy Bridge-EX processor > testcase: vm-sc

Re: [PATCH 4/4] sched: bias to target cpu load to reduce task moving

2013-12-04 Thread Yuanhan Liu
On Tue, Dec 03, 2013 at 05:05:56PM +0800, Alex Shi wrote: > Task migration happens when target just a bit less then source cpu load. > To reduce such situation happens, aggravate the target cpu load with > sd->imbalance_pct/100. > > This patch removes the hackbench thread regression on Daniel's >

[PATCH 4/4] sched: bias to target cpu load to reduce task moving

2013-12-03 Thread Alex Shi
Task migration happens when target just a bit less then source cpu load. To reduce such situation happens, aggravate the target cpu load with sd->imbalance_pct/100. This patch removes the hackbench thread regression on Daniel's Intel Core2 server. a5d6e63 +patch1~3 +patch1~4