On Tue, Dec 17, 2013 at 02:10:12PM +0000, Morten Rasmussen wrote: > > @@ -4135,7 +4141,7 @@ find_idlest_group(struct sched_domain *sd, struct > > task_struct *p, int this_cpu) > > if (local_group) > > load = source_load(i); > > else > > - load = target_load(i); > > + load = target_load(i, sd->imbalance_pct); > > Don't you apply imbalance_pct twice here? Later on in > find_idlest_group() you have: > > if (!idlest || 100*this_load < imbalance*min_load) > return NULL; > > where min_load comes from target_load().
Yes! exactly! this doesn't make any sense. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/