Re: [rtc-linux] [PATCH 4/4] RTC: switch to using is_visible() to control sysfs attributes

2015-07-22 Thread Krzysztof Kozlowski
2015-07-23 5:57 GMT+09:00 Alexandre Belloni : > (Krzysztof, be careful, Dmitry was not in copy of your maili, you should > probably check your mailer config) Right, I need to fix my Google group settings. Thank you for pointing this. Probably my other emails also were not sent to Dmitry... Best r

Re: [rtc-linux] [PATCH 4/4] RTC: switch to using is_visible() to control sysfs attributes

2015-07-22 Thread Dmitry Torokhov
On Wed, Jul 22, 2015 at 10:57:35PM +0200, Alexandre Belloni wrote: > (Krzysztof, be careful, Dmitry was not in copy of your maili, you should > probably check your mailer config) > > On 21/07/2015 at 10:21:11 +0900, Krzysztof Kozlowski wrote : > > 2015-07-21 8:02 GMT+09:00 Dmitry Torokhov : > > >

Re: [rtc-linux] [PATCH 4/4] RTC: switch to using is_visible() to control sysfs attributes

2015-07-22 Thread Alexandre Belloni
(Krzysztof, be careful, Dmitry was not in copy of your maili, you should probably check your mailer config) On 21/07/2015 at 10:21:11 +0900, Krzysztof Kozlowski wrote : > 2015-07-21 8:02 GMT+09:00 Dmitry Torokhov : > > static ssize_t > > -rtc_sysfs_set_wakealarm(struct device *dev, struct device_

Re: [PATCH 4/4] RTC: switch to using is_visible() to control sysfs attributes

2015-07-22 Thread Alexandre Belloni
Hi, Seems mostly good, a few comments on top of Krzysztof's below: On 20/07/2015 at 16:02:52 -0700, Dmitry Torokhov wrote : > Instead of creating an attribute manually, after the device has been > registered, let's rely on facilities provided by the attribute groups to > control which attributes

Re: [rtc-linux] [PATCH 4/4] RTC: switch to using is_visible() to control sysfs attributes

2015-07-20 Thread Krzysztof Kozlowski
2015-07-21 8:02 GMT+09:00 Dmitry Torokhov : > Instead of creating an attribute manually, after the device has been > registered, let's rely on facilities provided by the attribute groups to > control which attributes are visible and which are not. This allows to to > create all needed attributes at

[PATCH 4/4] RTC: switch to using is_visible() to control sysfs attributes

2015-07-20 Thread Dmitry Torokhov
Instead of creating an attribute manually, after the device has been registered, let's rely on facilities provided by the attribute groups to control which attributes are visible and which are not. This allows to to create all needed attributes at once, at the same time that we register RTC class d