Hi, Seems mostly good, a few comments on top of Krzysztof's below:
On 20/07/2015 at 16:02:52 -0700, Dmitry Torokhov wrote : > Instead of creating an attribute manually, after the device has been > registered, let's rely on facilities provided by the attribute groups to > control which attributes are visible and which are not. This allows to to too many 'to' here --------------------------------------------------^ [...] > -void __init rtc_sysfs_init(struct class *rtc_class) > +const struct attribute_group** rtc_get_dev_attribute_groups(void) That space is not properly placed ^, this should be: const struct attribute_group **rtc_get_dev_attribute_groups(void) -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
