Re: [PATCH 3/5] perf gtk/hists: Display callchain overhead also

2013-06-01 Thread Namhyung Kim
Hi Ingo, On Tue, May 28, 2013 at 5:48 PM, Ingo Molnar wrote: > > * Arnaldo Carvalho de Melo wrote: > >> Em Wed, May 22, 2013 at 05:27:36PM +0900, Namhyung Kim escreveu: >> > From: Namhyung Kim >> > >> > Add a new column for showing callchain overhead. I feel like it's >> > more natural than ha

Re: [PATCH 3/5] perf gtk/hists: Display callchain overhead also

2013-05-28 Thread Ingo Molnar
* Arnaldo Carvalho de Melo wrote: > Em Wed, May 22, 2013 at 05:27:36PM +0900, Namhyung Kim escreveu: > > From: Namhyung Kim > > > > Add a new column for showing callchain overhead. I feel like it's > > more natural than having those overhead next to a first child in a > > same column. > > Ca

Re: [PATCH 3/5] perf gtk/hists: Display callchain overhead also

2013-05-22 Thread Namhyung Kim
Hi Arnaldo, Good to see you :) On Wed, 22 May 2013 11:52:15 +0200, Arnaldo Carvalho de Melo wrote: > Em Wed, May 22, 2013 at 05:27:36PM +0900, Namhyung Kim escreveu: >> From: Namhyung Kim >> >> Add a new column for showing callchain overhead. I feel like it's >> more natural than having those

Re: [PATCH 3/5] perf gtk/hists: Display callchain overhead also

2013-05-22 Thread Arnaldo Carvalho de Melo
Em Wed, May 22, 2013 at 05:27:36PM +0900, Namhyung Kim escreveu: > From: Namhyung Kim > > Add a new column for showing callchain overhead. I feel like it's > more natural than having those overhead next to a first child in a > same column. Callchains in GTK, great! Some observations tho: All t

Re: [PATCH 3/5] perf gtk/hists: Display callchain overhead also

2013-05-22 Thread Pekka Enberg
On 05/22/2013 11:27 AM, Namhyung Kim wrote: From: Namhyung Kim Add a new column for showing callchain overhead. I feel like it's more natural than having those overhead next to a first child in a same column. Cc: Pekka Enberg Signed-off-by: Namhyung Kim Reviewed-by: Pekka Enberg -- To u

[PATCH 3/5] perf gtk/hists: Display callchain overhead also

2013-05-22 Thread Namhyung Kim
From: Namhyung Kim Add a new column for showing callchain overhead. I feel like it's more natural than having those overhead next to a first child in a same column. Cc: Pekka Enberg Signed-off-by: Namhyung Kim --- tools/perf/ui/gtk/hists.c | 44 ++-- 1