Hi Arnaldo, Good to see you :)
On Wed, 22 May 2013 11:52:15 +0200, Arnaldo Carvalho de Melo wrote: > Em Wed, May 22, 2013 at 05:27:36PM +0900, Namhyung Kim escreveu: >> From: Namhyung Kim <namhyung....@lge.com> >> >> Add a new column for showing callchain overhead. I feel like it's >> more natural than having those overhead next to a first child in a >> same column. > > Callchains in GTK, great! Some observations tho: > > All those leaves with 0.00% looks ugly/not needed, right? Right. But I'd rather say it's a bug of callchain code. :) > > I took a screenshot and put at: > > http://vger.kernel.org/~acme/perf-gtk-callchains.png > > all those duplicated "+ callchain" when the callchain is folded, can you > remove those? I.e. leaving just the '+' to allow unfolding. Sure. > > About using an extra column for the callchains... Can't it be like in > the TUI and in the stdio modes? Think about C++ long symbol names :-) That's why I made the columns resizable. I also thought about reusing the existing overhead and symbols columns. But I thought it might be confusing to contains two different info in a same column. But I'm not sure what's the better. > > I'll do some more testing on it and provide further comments, thanks for > doing this work! Thanks a lot! Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
