Hi Linus,
On Sat, Oct 18, 2014 at 02:56:39PM +0200, Linus Walleij wrote:
> + if (variant->set_pullup) {
> + u8 val;
> +
> + ret = stmpe_reg_read(stmpe, pureg);
> + if (ret)
> + return ret;
> +
> + /* Do not touch unused pins,
All keypad column pins used as inputs should be pulled up
on the STMPE24xx, but this is not done by the current driver.
Add some logic that will do this properly. The STMPE1601 also
has a keypad controller, but explicitly does *NOT* require
you to set up any pull-ups.
Signed-off-by: Linus Walleij
2 matches
Mail list logo
