Hi Linus,
On Sat, Oct 18, 2014 at 02:56:39PM +0200, Linus Walleij wrote:
> + if (variant->set_pullup) {
> + u8 val;
> +
> + ret = stmpe_reg_read(stmpe, pureg);
> + if (ret)
> + return ret;
> +
> + /* Do not touch unused pins, may be used for GPIO */
> + val = ret & ~pu_pins;
> + val |= pu_pins;
> +
> + ret = stmpe_reg_write(stmpe, pureg, val);
Don't we need
if (ret) {
dev_err(...);
return ret;
}
here?
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
