Re: [PATCH 3/3] fsi/master-gpio: Add external mode

2017-06-21 Thread Jeremy Kerr
Hi Joel, >> +static ssize_t external_mode_show(struct device *dev, >> + struct device_attribute *attr, char *buf) >> +{ >> + struct fsi_master_gpio *master = dev_get_drvdata(dev); >> + >> + return snprintf(buf, PAGE_SIZE - 1, "%u", > > I gave this a spin on a machine tod

Re: [PATCH 3/3] fsi/master-gpio: Add external mode

2017-06-20 Thread Joel Stanley
Hi Jeremy, On Mon, Jun 19, 2017 at 6:56 PM, Jeremy Kerr wrote: > This change introduces an 'external mode' for GPIO-based FSI masters, > +static ssize_t external_mode_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + struct fsi_master_gpio *master

Re: [PATCH 3/3] fsi/master-gpio: Add external mode

2017-06-19 Thread kbuild test robot
Hi Jeremy, [auto build test ERROR on next-20170619] [cannot apply to linus/master linux/master v4.12-rc5 v4.12-rc4 v4.12-rc3 v4.12-rc6] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Jeremy-Ker

[PATCH 3/3] fsi/master-gpio: Add external mode

2017-06-19 Thread Jeremy Kerr
This change introduces an 'external mode' for GPIO-based FSI masters, allowing the clock and data lines to be driven by an external source. For example, external mode is selected by a user when an external debug device is attached to the FSI pins. To do this, we need to set specific states for the