Hi Jeremy, On Mon, Jun 19, 2017 at 6:56 PM, Jeremy Kerr <j...@ozlabs.org> wrote: > This change introduces an 'external mode' for GPIO-based FSI masters, > +static ssize_t external_mode_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + struct fsi_master_gpio *master = dev_get_drvdata(dev); > + > + return snprintf(buf, PAGE_SIZE - 1, "%u",
I gave this a spin on a machine today and noticed we're missing a newline there. Should this be "%u\n"? Cheers, Joel > + master->external_mode ? 1 : 0); > +} > +