Re: [PATCH 2/4] Renames variable to fix shadow warning.

2018-10-17 Thread Ingo Molnar
* Leonardo Bras wrote: > Thanks Ingo, > On Wed, Oct 17, 2018 at 3:01 AM Ingo Molnar wrote: > > > > > > * Leonardo Brás wrote: > > > > > Renames the char variable to avoid shadowing a variable previously > > > declared on this function. > > > > > > Signed-off-by: Leonardo Brás > > > --- > > >

Re: [PATCH 2/4] Renames variable to fix shadow warning.

2018-10-17 Thread Leonardo Bras
Hello Andy, Thanks for the suggestion. I renamed them as suggested and it will be available on v2. Regards, Leonardo On Wed, Oct 17, 2018 at 2:54 PM Andy Lutomirski wrote: > > On Tue, Oct 16, 2018 at 11:01 PM Ingo Molnar wrote: > > > > > > * Leonardo Brás wrote: > > > > > Renames the char var

Re: [PATCH 2/4] Renames variable to fix shadow warning.

2018-10-17 Thread Leonardo Bras
Thanks Ingo, On Wed, Oct 17, 2018 at 3:01 AM Ingo Molnar wrote: > > > * Leonardo Brás wrote: > > > Renames the char variable to avoid shadowing a variable previously > > declared on this function. > > > > Signed-off-by: Leonardo Brás > > --- > > arch/x86/entry/vdso/vdso2c.h | 4 ++-- > > 1 file

Re: [Lkcamp] [PATCH 2/4] Renames variable to fix shadow warning.

2018-10-17 Thread Leonardo Bras
Hello Helen, Thanks for the suggestions! On Tue, Oct 16, 2018 at 11:57 PM Helen Koike wrote: > > Hi Leonardo, > > Thanks for the patch, just some small comments below. > > Please, check previous log messages with git log > arch/x86/entry/vdso/vdso2c.h, you will see that most patches had the > pre

Re: [PATCH 2/4] Renames variable to fix shadow warning.

2018-10-17 Thread Andy Lutomirski
On Tue, Oct 16, 2018 at 11:01 PM Ingo Molnar wrote: > > > * Leonardo Brás wrote: > > > Renames the char variable to avoid shadowing a variable previously > > declared on this function. > > > > Signed-off-by: Leonardo Brás > > --- > > arch/x86/entry/vdso/vdso2c.h | 4 ++-- > > 1 file changed, 2

Re: [PATCH 2/4] Renames variable to fix shadow warning.

2018-10-16 Thread Ingo Molnar
* Leonardo Brás wrote: > Renames the char variable to avoid shadowing a variable previously > declared on this function. > > Signed-off-by: Leonardo Brás > --- > arch/x86/entry/vdso/vdso2c.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/entry/vdso/vds

Re: [Lkcamp] [PATCH 2/4] Renames variable to fix shadow warning.

2018-10-16 Thread Helen Koike
Hi Leonardo, Thanks for the patch, just some small comments below. Please, check previous log messages with git log arch/x86/entry/vdso/vdso2c.h, you will see that most patches had the prefix "x86/vdso:" in the commit message. On 10/16/18 9:08 PM, Leonardo Brás wrote: > Renames the char variable

[PATCH 2/4] Renames variable to fix shadow warning.

2018-10-16 Thread Leonardo Brás
Renames the char variable to avoid shadowing a variable previously declared on this function. Signed-off-by: Leonardo Brás --- arch/x86/entry/vdso/vdso2c.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/entry/vdso/vdso2c.h b/arch/x86/entry/vdso/vdso2c.h index fa