Re: [PATCH 2/2 V2] workqueue: remove the argument @wakeup from worker_set_flags()

2014-07-22 Thread Tejun Heo
On Tue, Jul 22, 2014 at 01:02:00PM +0800, Lai Jiangshan wrote: > worker_set_flags() doesn't necessarily wake next worker and the @wakeup > can be removed, the caller can use the following conbination instead > when needed: > > worker_set_flags(); > if (need_more_worker(pool)) >

[PATCH 2/2 V2] workqueue: remove the argument @wakeup from worker_set_flags()

2014-07-21 Thread Lai Jiangshan
worker_set_flags() doesn't necessarily wake next worker and the @wakeup can be removed, the caller can use the following conbination instead when needed: worker_set_flags(); if (need_more_worker(pool)) wake_up_worker(pool); It reduces the machine-code and footprint