Re: [PATCH 2/2] scsi: ufs-qcom: Add one sysfs node to monitor performance

2021-01-05 Thread Can Guo
On 2021-01-05 18:27, Greg KH wrote: Oops, forgot the big problem that I noticed: On Mon, Jan 04, 2021 at 07:15:51PM -0800, Can Guo wrote: +static ssize_t monitor_show(struct device *dev, struct device_attribute *attr, + char *buf) +{ + struct ufs_hba *hba = dev_

Re: [PATCH 2/2] scsi: ufs-qcom: Add one sysfs node to monitor performance

2021-01-05 Thread Greg KH
Oops, forgot the big problem that I noticed: On Mon, Jan 04, 2021 at 07:15:51PM -0800, Can Guo wrote: > +static ssize_t monitor_show(struct device *dev, struct device_attribute > *attr, > + char *buf) > +{ > + struct ufs_hba *hba = dev_get_drvdata(dev); > + struct

Re: [PATCH 2/2] scsi: ufs-qcom: Add one sysfs node to monitor performance

2021-01-05 Thread Greg KH
On Mon, Jan 04, 2021 at 07:15:51PM -0800, Can Guo wrote: > Add one sysfs node to monitor driver layer performance data. One can > manipulate it to get performance related statistics during runtime. > > Signed-off-by: Can Guo You did not create a Documentation/ABI/ update for this, explaining how

[PATCH 2/2] scsi: ufs-qcom: Add one sysfs node to monitor performance

2021-01-04 Thread Can Guo
Add one sysfs node to monitor driver layer performance data. One can manipulate it to get performance related statistics during runtime. Signed-off-by: Can Guo diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c index 2206b1e..5303ce9 100644 --- a/drivers/scsi/ufs/ufs-qcom.c +