Re: [PATCH 2/2] sched/fair: Relax task_hot() for misfit tasks

2021-04-20 Thread Vincent Guittot
On Mon, 19 Apr 2021 at 19:13, Valentin Schneider wrote: > > On 16/04/21 15:51, Vincent Guittot wrote: > > Le jeudi 15 avril 2021 � 18:58:46 (+0100), Valentin Schneider a �crit : > >> + > >> +/* > >> + * What does migrating this task do to our capacity-aware scheduling > >> criterion? > >> + *

Re: [PATCH 2/2] sched/fair: Relax task_hot() for misfit tasks

2021-04-19 Thread Phil Auld
On Mon, Apr 19, 2021 at 06:17:47PM +0100 Valentin Schneider wrote: > On 19/04/21 08:59, Phil Auld wrote: > > On Fri, Apr 16, 2021 at 10:43:38AM +0100 Valentin Schneider wrote: > >> On 15/04/21 16:39, Rik van Riel wrote: > >> > On Thu, 2021-04-15 at 18:58 +0100, Valentin Schneider wrote: > >> >> @@

Re: [PATCH 2/2] sched/fair: Relax task_hot() for misfit tasks

2021-04-19 Thread Valentin Schneider
On 19/04/21 08:59, Phil Auld wrote: > On Fri, Apr 16, 2021 at 10:43:38AM +0100 Valentin Schneider wrote: >> On 15/04/21 16:39, Rik van Riel wrote: >> > On Thu, 2021-04-15 at 18:58 +0100, Valentin Schneider wrote: >> >> @@ -7672,6 +7698,15 @@ int can_migrate_task(struct task_struct *p, >> >> struct

Re: [PATCH 2/2] sched/fair: Relax task_hot() for misfit tasks

2021-04-19 Thread Valentin Schneider
On 16/04/21 15:51, Vincent Guittot wrote: > Le jeudi 15 avril 2021 � 18:58:46 (+0100), Valentin Schneider a �crit : >> + >> +/* >> + * What does migrating this task do to our capacity-aware scheduling >> criterion? >> + * >> + * Returns 1, if the task needs more capacity than the dst CPU can p

Re: [PATCH 2/2] sched/fair: Relax task_hot() for misfit tasks

2021-04-19 Thread Phil Auld
On Fri, Apr 16, 2021 at 10:43:38AM +0100 Valentin Schneider wrote: > On 15/04/21 16:39, Rik van Riel wrote: > > On Thu, 2021-04-15 at 18:58 +0100, Valentin Schneider wrote: > >> Consider the following topology: > >> > >> Long story short, preempted misfit tasks are affected by task_hot(), > >> whil

Re: [PATCH 2/2] sched/fair: Relax task_hot() for misfit tasks

2021-04-16 Thread Vincent Guittot
Le jeudi 15 avril 2021 à 18:58:46 (+0100), Valentin Schneider a écrit : > Consider the following topology: > > DIE [ ] > MC [][] >0 1 2 3 > > capacity_orig_of(x \in {0-1}) < capacity_orig_of(x \in {2-3}) > > w/ CPUs 2-3 idle and CPUs 0-1 running CPU hogs (util_

Re: [PATCH 2/2] sched/fair: Relax task_hot() for misfit tasks

2021-04-16 Thread Valentin Schneider
On 15/04/21 16:39, Rik van Riel wrote: > On Thu, 2021-04-15 at 18:58 +0100, Valentin Schneider wrote: >> Consider the following topology: >> >> Long story short, preempted misfit tasks are affected by task_hot(), >> while >> currently running misfit tasks are intentionally preempted by the >> stopp

Re: [PATCH 2/2] sched/fair: Relax task_hot() for misfit tasks

2021-04-15 Thread Rik van Riel
On Thu, 2021-04-15 at 18:58 +0100, Valentin Schneider wrote: > Consider the following topology: > > Long story short, preempted misfit tasks are affected by task_hot(), > while > currently running misfit tasks are intentionally preempted by the > stopper > task to migrate them over to a higher-cap

[PATCH 2/2] sched/fair: Relax task_hot() for misfit tasks

2021-04-15 Thread Valentin Schneider
Consider the following topology: DIE [ ] MC [][] 0 1 2 3 capacity_orig_of(x \in {0-1}) < capacity_orig_of(x \in {2-3}) w/ CPUs 2-3 idle and CPUs 0-1 running CPU hogs (util_avg=1024). When CPU2 goes through load_balance() (via periodic / NOHZ balance), it should