Re: [PATCH 2/2] hwrng: msm: Add PRNG support for MSM SoC's

2013-10-09 Thread Stanimir Varbanov
Hi Stephen, On 10/04/2013 07:37 PM, Stephen Boyd wrote: > On 10/04/13 09:31, Stanimir Varbanov wrote: >> +static int msm_rng_probe(struct platform_device *pdev) +{ + struct msm_rng *rng; + struct device_node *np; + struct resource res; + int ret; + + np

Re: [PATCH 2/2] hwrng: msm: Add PRNG support for MSM SoC's

2013-10-04 Thread Stephen Boyd
On 10/04/13 09:31, Stanimir Varbanov wrote: > >>> +static int msm_rng_probe(struct platform_device *pdev) >>> +{ >>> + struct msm_rng *rng; >>> + struct device_node *np; >>> + struct resource res; >>> + int ret; >>> + >>> + np = of_node_get(pdev->dev.of_node); >>> + if (!np) >>> +

Re: [PATCH 2/2] hwrng: msm: Add PRNG support for MSM SoC's

2013-10-04 Thread Stanimir Varbanov
Hi Stephen, Thanks for the quick review! On 10/03/2013 10:25 PM, Stephen Boyd wrote: > On 10/03/13 07:52, Stanimir Varbanov wrote: >> +#define PRNG_CONFIG_MASK0x0002 >> +#define PRNG_CONFIG_HW_ENABLE BIT(1) > > These two are the same so please drop the PRNG_CONFIG_MASK define and >

Re: [PATCH 2/2] hwrng: msm: Add PRNG support for MSM SoC's

2013-10-03 Thread Stephen Boyd
On 10/03/13 07:52, Stanimir Varbanov wrote: > +#define PRNG_CONFIG_MASK 0x0002 > +#define PRNG_CONFIG_HW_ENABLEBIT(1) These two are the same so please drop the PRNG_CONFIG_MASK define and just use the PRNG_CONFIG_HW_ENABLE define. > +#define PRNG_STATUS_DATA_AVAIL BIT(0) > +

[PATCH 2/2] hwrng: msm: Add PRNG support for MSM SoC's

2013-10-03 Thread Stanimir Varbanov
This adds a driver for hardware random number generator present on Qualcomm MSM SoC's. Signed-off-by: Stanimir Varbanov --- drivers/char/hw_random/Kconfig | 12 +++ drivers/char/hw_random/Makefile | 1 + drivers/char/hw_random/msm-rng.c | 211 +++ 3 file