Re: [PATCH 2/2] driver core: platform: provide devm_platform_iounremap_resource

2020-10-05 Thread Greg KH
On Mon, Oct 05, 2020 at 11:23:18PM +0800, pierre kuo wrote: > hi Greg: > > Why are you adding new functions but not actually calling them anywhere? > > Below patch introduce a single helper, devm_platform_ioremap_resource, > which combines > platform_get_resource() and devm_ioremap_resource(). But

Re: [PATCH 2/2] driver core: platform: provide devm_platform_iounremap_resource

2020-10-05 Thread pierre kuo
hi Greg: > Why are you adding new functions but not actually calling them anywhere? Below patch introduce a single helper, devm_platform_ioremap_resource, which combines platform_get_resource() and devm_ioremap_resource(). But there is no single helper to release those resources in driver removing

Re: [PATCH 2/2] driver core: platform: provide devm_platform_iounremap_resource

2020-10-04 Thread Greg KH
On Mon, Oct 05, 2020 at 12:21:12AM +0800, pierre kuo wrote: > hi Greg: > > Please resend, I can't take patches off of a random web site. > > Now lore.kernel.org I could take them from :) > > Please refer to the attachments and links on lore.kernel.org. > > https://lore.kernel.org/lkml/20200920113

Re: [PATCH 2/2] driver core: platform: provide devm_platform_iounremap_resource

2020-10-04 Thread pierre kuo
pierre Kuo Date: Wed, 19 Aug 2020 15:57:05 +0800 Subject: [PATCH 2/2] driver core: platform: provide devm_platform_iounremap_resource Combine platform_get_resource() and devm_iounremap_resource() to release the iomem allocated by devm_platform_get_and_ioremap_resource(). Signed-off-by: pierre Kuo

Re: [PATCH 2/2] driver core: platform: provide devm_platform_iounremap_resource

2020-10-02 Thread Greg KH
On Tue, Sep 29, 2020 at 02:21:37PM +0800, pierre kuo wrote: > Hi Greg and Rafael: > Would you please help to review these 2 patches? > > https://lkml.org/lkml/2020/9/20/112 > https://lkml.org/lkml/2020/9/20/113 Please resend, I can't take patches off of a random web site. Now lore.kernel.org I c

Re: [PATCH 2/2] driver core: platform: provide devm_platform_iounremap_resource

2020-09-28 Thread pierre kuo
Hi Greg and Rafael: Would you please help to review these 2 patches? https://lkml.org/lkml/2020/9/20/112 https://lkml.org/lkml/2020/9/20/113 Appreciate ur help in advance. > > Combine platform_get_resource() and devm_iounremap_resource() to release > the iomem allocated by devm_platform_get_and_

[PATCH 2/2] driver core: platform: provide devm_platform_iounremap_resource

2020-09-20 Thread pierre Kuo
Combine platform_get_resource() and devm_iounremap_resource() to release the iomem allocated by devm_platform_get_and_ioremap_resource(). Signed-off-by: pierre Kuo --- drivers/base/platform.c | 24 include/linux/platform_device.h | 4 2 files changed, 28 in