On Mon, Oct 05, 2020 at 11:23:18PM +0800, pierre kuo wrote: > hi Greg: > > Why are you adding new functions but not actually calling them anywhere? > > Below patch introduce a single helper, devm_platform_ioremap_resource, > which combines > platform_get_resource() and devm_ioremap_resource(). But there is no > single helper to release > those resources in driver removing stage. > > https://lore.kernel.org/lkml/20190215152507.31066-2-b...@bgdev.pl/ > > That means driver owner still need to call below (*) and (**) for > releasing resource. > Therefore, this patch adds a single release helper that can be paired with > devm_platform_ioremap_resource. > > Appreciate ur kind help, > > foo_probe(pdev) > { > iomem = devm_platform_ioremap_resource(pdev, 0); > .... > } > > > foo_remove(pdev) > { > devm_iounmap(iomem); (*) > devm_release_mem_region(dev, res->start, size); (**) > ........................ > }
I don't understand this at all, sorry. Please submit your patch series, with some drivers converted to use the new functions. Otherwise we can not properly review it. thanks, greg k-h
