Re: about the flood of trivial patches and the Code of Conduct (was: Re: [PATCH 19/25] sched: Use bool function return values of true/false not 1/0)

2015-04-13 Thread One Thousand Gnomes
> Besides, old code is somewhat like an ancient building. Yes, it needs to be > kept in a good shape, but you won't replace bricks in it just because they are > old, will you? When they matter to the integrity and they are likely to be full of internal cracks and holes you do. What concerns me m

Re: about the flood of trivial patches and the Code of Conduct (was: Re: [PATCH 19/25] sched: Use bool function return values of true/false not 1/0)

2015-04-08 Thread Joe Perches
On Thu, 2015-04-09 at 01:37 +0200, Rafael J. Wysocki wrote: > old code is somewhat like an ancient building. Yes, it needs to be > kept in a good shape, but you won't replace bricks in it just because they are > old, will you? No, but you do have to replace/repoint the mortar as it ages. Here in

Re: about the flood of trivial patches and the Code of Conduct (was: Re: [PATCH 19/25] sched: Use bool function return values of true/false not 1/0)

2015-04-08 Thread Rafael J. Wysocki
On Tuesday, April 07, 2015 09:28:03 AM Steven Rostedt wrote: > On Tue, Apr 07, 2015 at 02:31:23PM +0200, Rafael J. Wysocki wrote: > > > > > > As per the other branch of this tree; an emphatic NO to that. The > > > trivial tree is not a backdoor to bypass maintainers. Actual code > > > changes do n

Re: about the flood of trivial patches and the Code of Conduct (was: Re: [PATCH 19/25] sched: Use bool function return values of true/false not 1/0)

2015-04-07 Thread Theodore Ts'o
On Tue, Apr 07, 2015 at 01:32:12PM +0200, Peter Zijlstra wrote: > > I propose to send all this stuff though the trivial tree such that > > maintainers > > of other subsystems have less workload and newbies (which are supposed > > to send such patches) know which tree they have to work against. > >

Re: about the flood of trivial patches and the Code of Conduct (was: Re: [PATCH 19/25] sched: Use bool function return values of true/false not 1/0)

2015-04-07 Thread Steven Rostedt
On Tue, Apr 07, 2015 at 02:31:23PM +0200, Rafael J. Wysocki wrote: > > > > As per the other branch of this tree; an emphatic NO to that. The > > trivial tree is not a backdoor to bypass maintainers. Actual code > > changes do not get to go through any tree but the maintainer tree unless > > explic

Re: about the flood of trivial patches and the Code of Conduct (was: Re: [PATCH 19/25] sched: Use bool function return values of true/false not 1/0)

2015-04-07 Thread Joe Perches
On Tue, 2015-04-07 at 11:12 +0200, Ingo Molnar wrote: > I don't think you have answered PeterZ's > legitimate technical question adequately: As I wrote before, ~13000:180 is a big ratio. http://www.kernelhub.org/?p=2&msg=718145 > what are the technological > justifications for doing this 25 pat

Re: about the flood of trivial patches and the Code of Conduct (was: Re: [PATCH 19/25] sched: Use bool function return values of true/false not 1/0)

2015-04-07 Thread Rafael J. Wysocki
On Tuesday, April 07, 2015 01:32:12 PM Peter Zijlstra wrote: > On Tue, Apr 07, 2015 at 01:28:27PM +0200, Richard Weinberger wrote: > > Can't we send all these kind of patches through the trivial tree? > > Don't get me wrong, if you are fine with these patches that's you decision. > > But other main

Re: about the flood of trivial patches and the Code of Conduct (was: Re: [PATCH 19/25] sched: Use bool function return values of true/false not 1/0)

2015-04-07 Thread Peter Zijlstra
On Tue, Apr 07, 2015 at 01:28:27PM +0200, Richard Weinberger wrote: > Can't we send all these kind of patches through the trivial tree? > Don't get me wrong, if you are fine with these patches that's you decision. > But other maintainers might think they have to take these patches and > get overloa

Re: about the flood of trivial patches and the Code of Conduct (was: Re: [PATCH 19/25] sched: Use bool function return values of true/false not 1/0)

2015-04-07 Thread Richard Weinberger
On Tue, Apr 7, 2015 at 1:00 PM, Greg Kroah-Hartman wrote: > On Tue, Apr 07, 2015 at 11:12:46AM +0200, Ingo Molnar wrote: >> Pointing out this truth and protecting against such abusive flood of >> trivial patches is not against the code of conduct I signed. > > I totally agree, it's not "against" t

Re: about the flood of trivial patches and the Code of Conduct (was: Re: [PATCH 19/25] sched: Use bool function return values of true/false not 1/0)

2015-04-07 Thread Peter Zijlstra
On Tue, Apr 07, 2015 at 01:18:56PM +0200, Ingo Molnar wrote: > > * Greg Kroah-Hartman wrote: > > > On Tue, Apr 07, 2015 at 11:12:46AM +0200, Ingo Molnar wrote: > > > Pointing out this truth and protecting against such abusive flood of > > > trivial patches is not against the code of conduct I s

Re: about the flood of trivial patches and the Code of Conduct (was: Re: [PATCH 19/25] sched: Use bool function return values of true/false not 1/0)

2015-04-07 Thread Ingo Molnar
* Greg Kroah-Hartman wrote: > On Tue, Apr 07, 2015 at 11:12:46AM +0200, Ingo Molnar wrote: > > Pointing out this truth and protecting against such abusive flood of > > trivial patches is not against the code of conduct I signed. > > I totally agree, it's not "against" the code of conflict that

Re: about the flood of trivial patches and the Code of Conduct (was: Re: [PATCH 19/25] sched: Use bool function return values of true/false not 1/0)

2015-04-07 Thread Greg Kroah-Hartman
On Tue, Apr 07, 2015 at 11:12:46AM +0200, Ingo Molnar wrote: > Pointing out this truth and protecting against such abusive flood of > trivial patches is not against the code of conduct I signed. I totally agree, it's not "against" the code of conflict that I helped write. Joe, you know better th

Re: about the flood of trivial patches and the Code of Conflict (was: Re: [PATCH 19/25] sched: Use bool function return values of true/false not 1/0)

2015-04-07 Thread Ingo Molnar
* Ingo Molnar wrote: > > I also think you are beginning to abuse the openness of kernel > > maintainers to apply trivial patches, and I don't think it's > > useful to point out such abuse before it gets worse. and this should read: > > I also think you are beginning to abuse the openness of

Re: about the flood of trivial patches and the Code of Conflict (was: Re: [PATCH 19/25] sched: Use bool function return values of true/false not 1/0)

2015-04-07 Thread Ingo Molnar
s/Conduct/Conflict * Ingo Molnar wrote: > > * Joe Perches wrote: > > > On Tue, 2015-03-31 at 11:03 +0200, Ingo Molnar wrote: > > > * Peter Zijlstra wrote: > > > > On Mon, Mar 30, 2015 at 04:46:17PM -0700, Joe Perches wrote: > > > > > Use the normal return values for bool functions > > > > >

Re: about the flood of trivial patches and the Code of Conduct (was: Re: [PATCH 19/25] sched: Use bool function return values of true/false not 1/0)

2015-04-07 Thread Ingo Molnar
* Ingo Molnar wrote: > > * Joe Perches wrote: > > > On Tue, 2015-03-31 at 11:03 +0200, Ingo Molnar wrote: > > > * Peter Zijlstra wrote: > > > > On Mon, Mar 30, 2015 at 04:46:17PM -0700, Joe Perches wrote: > > > > > Use the normal return values for bool functions > > > > > > > > > > Update t

about the flood of trivial patches and the Code of Conduct (was: Re: [PATCH 19/25] sched: Use bool function return values of true/false not 1/0)

2015-04-07 Thread Ingo Molnar
* Joe Perches wrote: > On Tue, 2015-03-31 at 11:03 +0200, Ingo Molnar wrote: > > * Peter Zijlstra wrote: > > > On Mon, Mar 30, 2015 at 04:46:17PM -0700, Joe Perches wrote: > > > > Use the normal return values for bool functions > > > > > > > > Update the other sets of ret in try_wait_for_compl

Re: [PATCH 19/25] sched: Use bool function return values of true/false not 1/0

2015-03-31 Thread Peter Zijlstra
On Tue, Mar 31, 2015 at 09:46:40AM -0700, Joe Perches wrote: > On Tue, 2015-03-31 at 11:03 +0200, Ingo Molnar wrote: > > * Peter Zijlstra wrote: > > > On Mon, Mar 30, 2015 at 04:46:17PM -0700, Joe Perches wrote: > > > > Use the normal return values for bool functions > > > > > > > > Update the ot

Re: [PATCH 19/25] sched: Use bool function return values of true/false not 1/0

2015-03-31 Thread Jason Low
On Mon, Mar 30, 2015 at 4:46 PM, Joe Perches wrote: > * try_wait_for_completion - try to decrement a completion without > blocking > * @x: completion structure > * > - * Return: 0 if a decrement cannot be done without blocking > - * 1 if a decrement succeeded.

Re: [PATCH 19/25] sched: Use bool function return values of true/false not 1/0

2015-03-31 Thread Joe Perches
On Tue, 2015-03-31 at 11:03 +0200, Ingo Molnar wrote: > * Peter Zijlstra wrote: > > On Mon, Mar 30, 2015 at 04:46:17PM -0700, Joe Perches wrote: > > > Use the normal return values for bool functions > > > > > > Update the other sets of ret in try_wait_for_completion. > > > > I'm missing a why; w

Re: [PATCH 19/25] sched: Use bool function return values of true/false not 1/0

2015-03-31 Thread Joe Perches
On Tue, 2015-03-31 at 10:53 +0200, Peter Zijlstra wrote: > On Mon, Mar 30, 2015 at 04:46:17PM -0700, Joe Perches wrote: > > Use the normal return values for bool fsnctions > > > > Update the other sets of ret in try_wait_for_completion. > > I'm missing a why; why are you doing this? It's just a

Re: [PATCH 19/25] sched: Use bool function return values of true/false not 1/0

2015-03-31 Thread Ingo Molnar
* Peter Zijlstra wrote: > On Mon, Mar 30, 2015 at 04:46:17PM -0700, Joe Perches wrote: > > Use the normal return values for bool functions > > > > Update the other sets of ret in try_wait_for_completion. > > I'm missing a why; why are you doing this? Let me guess: Joe Perches is suffering fro

Re: [PATCH 19/25] sched: Use bool function return values of true/false not 1/0

2015-03-31 Thread Peter Zijlstra
On Mon, Mar 30, 2015 at 04:46:17PM -0700, Joe Perches wrote: > Use the normal return values for bool functions > > Update the other sets of ret in try_wait_for_completion. I'm missing a why; why are you doing this? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

[PATCH 19/25] sched: Use bool function return values of true/false not 1/0

2015-03-30 Thread Joe Perches
Use the normal return values for bool functions Update the other sets of ret in try_wait_for_completion. Signed-off-by: Joe Perches --- kernel/sched/auto_group.h | 2 +- kernel/sched/completion.c | 16 +--- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/kernel/sche