Re: [PATCH 1/9] remoteproc: core: Ensure error message is clear

2016-08-11 Thread Suman Anna
On 08/11/2016 02:19 PM, Bjorn Andersson wrote: > On Thu 11 Aug 00:36 PDT 2016, Lee Jones wrote: > >> On Wed, 10 Aug 2016, Suman Anna wrote: >> >>> On 08/09/2016 01:12 PM, Lee Jones wrote: On Tue, 09 Aug 2016, Bjorn Andersson wrote: > On Thu 04 Aug 02:21 PDT 2016, Lee Jones wrote: > [

Re: [PATCH 1/9] remoteproc: core: Ensure error message is clear

2016-08-11 Thread Bjorn Andersson
On Thu 11 Aug 00:36 PDT 2016, Lee Jones wrote: > On Wed, 10 Aug 2016, Suman Anna wrote: > > > On 08/09/2016 01:12 PM, Lee Jones wrote: > > > On Tue, 09 Aug 2016, Bjorn Andersson wrote: > > > > > >> On Thu 04 Aug 02:21 PDT 2016, Lee Jones wrote: [..] > > >>> - dev_dbg(dev, "carveout rsc: da

Re: [PATCH 1/9] remoteproc: core: Ensure error message is clear

2016-08-11 Thread Lee Jones
On Wed, 10 Aug 2016, Suman Anna wrote: > On 08/09/2016 01:12 PM, Lee Jones wrote: > > On Tue, 09 Aug 2016, Bjorn Andersson wrote: > > > >> On Thu 04 Aug 02:21 PDT 2016, Lee Jones wrote: > >> > >>> Before this patch, the dma_alloc_coherent() failure path printed out: > >>> > >>> "dma_alloc_coher

Re: [PATCH 1/9] remoteproc: core: Ensure error message is clear

2016-08-10 Thread Suman Anna
On 08/09/2016 01:12 PM, Lee Jones wrote: > On Tue, 09 Aug 2016, Bjorn Andersson wrote: > >> On Thu 04 Aug 02:21 PDT 2016, Lee Jones wrote: >> >>> Before this patch, the dma_alloc_coherent() failure path printed out: >>> >>> "dma_alloc_coherent err: 16760832" >>> >>> ... alluding to the Linux err

Re: [PATCH 1/9] remoteproc: core: Ensure error message is clear

2016-08-09 Thread Lee Jones
On Tue, 09 Aug 2016, Bjorn Andersson wrote: > On Thu 04 Aug 02:21 PDT 2016, Lee Jones wrote: > > > Before this patch, the dma_alloc_coherent() failure path printed out: > > > > "dma_alloc_coherent err: 16760832" > > > > ... alluding to the Linux error code being 16760832, but seeing as > > Li

Re: [PATCH 1/9] remoteproc: core: Ensure error message is clear

2016-08-09 Thread Bjorn Andersson
On Thu 04 Aug 02:21 PDT 2016, Lee Jones wrote: > Before this patch, the dma_alloc_coherent() failure path printed out: > > "dma_alloc_coherent err: 16760832" > > ... alluding to the Linux error code being 16760832, but seeing as > Linux error codes are all negative, this looks like a signed/un

[PATCH 1/9] remoteproc: core: Ensure error message is clear

2016-08-04 Thread Lee Jones
Before this patch, the dma_alloc_coherent() failure path printed out: "dma_alloc_coherent err: 16760832" ... alluding to the Linux error code being 16760832, but seeing as Linux error codes are all negative, this looks like a signed/unsigned issue. In fact, the message is trying to print the l