On Thu 04 Aug 02:21 PDT 2016, Lee Jones wrote:
> Before this patch, the dma_alloc_coherent() failure path printed out:
>
> "dma_alloc_coherent err: 16760832"
>
> ... alluding to the Linux error code being 16760832, but seeing as
> Linux error codes are all negative, this looks like a signed/unsigned
> issue. In fact, the message is trying to print the length of the
> requested memory region. Let's clear that up.
>
> While we're at it, let's standardise the way 'len' is printed. In
> all other locations 'len' is in hex prefixed by a '0x' for clarity.
>
> Signed-off-by: Lee Jones <lee.jo...@linaro.org>
Acked-by: Bjorn Andersson <bjorn.anders...@linaro.org>
Regards,
Bjorn
> ---
> drivers/remoteproc/remoteproc_core.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/remoteproc/remoteproc_core.c
> b/drivers/remoteproc/remoteproc_core.c
> index aea29a75c..3566dc9 100644
> --- a/drivers/remoteproc/remoteproc_core.c
> +++ b/drivers/remoteproc/remoteproc_core.c
> @@ -581,7 +581,7 @@ static int rproc_handle_carveout(struct rproc *rproc,
> return -EINVAL;
> }
>
> - dev_dbg(dev, "carveout rsc: da %x, pa %x, len %x, flags %x\n",
> + dev_dbg(dev, "carveout rsc: da %x, pa %x, len 0x%x, flags %x\n",
> rsc->da, rsc->pa, rsc->len, rsc->flags);
>
> carveout = kzalloc(sizeof(*carveout), GFP_KERNEL);
> @@ -590,7 +590,8 @@ static int rproc_handle_carveout(struct rproc *rproc,
>
> va = dma_alloc_coherent(dev->parent, rsc->len, &dma, GFP_KERNEL);
> if (!va) {
> - dev_err(dev->parent, "dma_alloc_coherent err: %d\n", rsc->len);
> + dev_err(dev->parent,
> + "failed to allocate dma memory: len 0x%x\n", rsc->len);
> ret = -ENOMEM;
> goto free_carv;
> }
> --
> 2.9.0
>
