Re: [PATCH 1/6] x86: drop unneded members of struct cpuinfo_x86

2017-02-14 Thread H. Peter Anvin
On 02/14/17 09:56, Geert Uytterhoeven wrote: >> >> Well, almost. You need the wp_works_ok removal patch too, otherwise you >> have the 3 bytes hole below. > > That's because you removed a char in commit 93a829e8e2c292f1 > ("x86, cpu: Convert FDIV bug detection), without compensating with padding ;

Re: [PATCH 1/6] x86: drop unneded members of struct cpuinfo_x86

2017-02-14 Thread Borislav Petkov
On Tue, Feb 14, 2017 at 06:56:22PM +0100, Geert Uytterhoeven wrote: > That's because No, what Mathias said. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.

Re: [PATCH 1/6] x86: drop unneded members of struct cpuinfo_x86

2017-02-14 Thread Geert Uytterhoeven
Hi Boris, On Tue, Feb 14, 2017 at 5:17 PM, Borislav Petkov wrote: > On Sun, Feb 12, 2017 at 10:12:07PM +0100, Mathias Krause wrote: >> Those member serve no purpose -- not even fill padding for alignment or >> such. So just get rid of them. > > Well, almost. You need the wp_works_ok removal patch

Re: [PATCH 1/6] x86: drop unneded members of struct cpuinfo_x86

2017-02-14 Thread Mathias Krause
On 14 February 2017 at 17:17, Borislav Petkov wrote: > On Sun, Feb 12, 2017 at 10:12:07PM +0100, Mathias Krause wrote: >> Those member serve no purpose -- not even fill padding for alignment or >> such. So just get rid of them. > > Well, almost. You need the wp_works_ok removal patch too, otherwis

Re: [PATCH 1/6] x86: drop unneded members of struct cpuinfo_x86

2017-02-14 Thread Borislav Petkov
On Sun, Feb 12, 2017 at 10:12:07PM +0100, Mathias Krause wrote: > Those member serve no purpose -- not even fill padding for alignment or > such. So just get rid of them. Well, almost. You need the wp_works_ok removal patch too, otherwise you have the 3 bytes hole below. But the wp_works_ok goes

[PATCH 1/6] x86: drop unneded members of struct cpuinfo_x86

2017-02-12 Thread Mathias Krause
Those member serve no purpose -- not even fill padding for alignment or such. So just get rid of them. Cc: Borislav Petkov Cc: H. Peter Anvin Signed-off-by: Mathias Krause --- arch/x86/include/asm/processor.h |7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/arch/x86