Re: [PATCH 1/5] ftrace: remove redundant strsep in mod_callback

2015-10-16 Thread Dmitry Safonov
2015-10-14 3:48 GMT+03:00 Steven Rostedt : >> - ret = ftrace_match_module_records(hash, func, mod); >> - if (!ret) >> - ret = -EINVAL; >> + ret = ftrace_match_module_records(hash, func, param); >> + if (ret == 0) > > Small nit, personally, I prefer the if (!ret) version.

Re: [PATCH 1/5] ftrace: remove redundant strsep in mod_callback

2015-10-13 Thread Steven Rostedt
On Tue, 29 Sep 2015 19:46:12 +0300 Dmitry Safonov <0x7f454...@gmail.com> wrote: > - ret = ftrace_match_module_records(hash, func, mod); > - if (!ret) > - ret = -EINVAL; > + ret = ftrace_match_module_records(hash, func, param); > + if (ret == 0) Small nit, personally,

Re: [PATCH 1/5] ftrace: remove redundant strsep in mod_callback

2015-10-05 Thread Дмитрий Сафонов
Hello again, Steven. I'm pinging :) 2015-09-29 22:11 GMT+03:00 Steven Rostedt : > On Tue, 29 Sep 2015 19:46:12 +0300 > Dmitry Safonov <0x7f454...@gmail.com> wrote: > >> By now there isn't any subcommand for mod. >> >> Before: >> sh$ echo '*:mod:ipv6:a' > set_ftrace_filter >> sh$ echo '

Re: [PATCH 1/5] ftrace: remove redundant strsep in mod_callback

2015-09-29 Thread Steven Rostedt
On Tue, 29 Sep 2015 19:46:12 +0300 Dmitry Safonov <0x7f454...@gmail.com> wrote: > By now there isn't any subcommand for mod. > > Before: > sh$ echo '*:mod:ipv6:a' > set_ftrace_filter > sh$ echo '*:mod:ipv6' > set_ftrace_filter > had the same results, but now first will result in: >

[PATCH 1/5] ftrace: remove redundant strsep in mod_callback

2015-09-29 Thread Dmitry Safonov
By now there isn't any subcommand for mod. Before: sh$ echo '*:mod:ipv6:a' > set_ftrace_filter sh$ echo '*:mod:ipv6' > set_ftrace_filter had the same results, but now first will result in: sh$ echo '*:mod:ipv6:a' > set_ftrace_filter -bash: echo: write error: Invalid