2015-10-14 3:48 GMT+03:00 Steven Rostedt <rost...@goodmis.org>: >> - ret = ftrace_match_module_records(hash, func, mod); >> - if (!ret) >> - ret = -EINVAL; >> + ret = ftrace_match_module_records(hash, func, param); >> + if (ret == 0) > > Small nit, personally, I prefer the if (!ret) version. > > For me "== 0" is for counters and strcmp. I may change this to be > consistent with the rest of the code. > > -- Steve Ok, I thought "== 0" will be more readable near comparison "< 0", but anyway, (!ret) is good.
> >> + return -EINVAL; >> if (ret < 0) >> return ret; >> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
