Re: [PATCH 1/3] Add a new field to struct shrinker

2016-08-11 Thread Tony Jones
On 07/29/2016 06:00 AM, Mel Gorman wrote: > On Fri, Jul 29, 2016 at 10:13:40AM +1000, Dave Chinner wrote: >> On Thu, Jul 28, 2016 at 11:25:13AM +0100, Mel Gorman wrote: >>> On Thu, Jul 28, 2016 at 03:49:47PM +1000, Dave Chinner wrote: Seems you're all missing the obvious. Add a trace

Re: [PATCH 1/3] Add a new field to struct shrinker

2016-07-29 Thread Mel Gorman
On Fri, Jul 29, 2016 at 10:13:40AM +1000, Dave Chinner wrote: > On Thu, Jul 28, 2016 at 11:25:13AM +0100, Mel Gorman wrote: > > On Thu, Jul 28, 2016 at 03:49:47PM +1000, Dave Chinner wrote: > > > Seems you're all missing the obvious. > > > > > > Add a tracepoint for a shrinker callback that includ

Re: [PATCH 1/3] Add a new field to struct shrinker

2016-07-28 Thread Dave Chinner
On Thu, Jul 28, 2016 at 11:25:13AM +0100, Mel Gorman wrote: > On Thu, Jul 28, 2016 at 03:49:47PM +1000, Dave Chinner wrote: > > Seems you're all missing the obvious. > > > > Add a tracepoint for a shrinker callback that includes a "name" > > field, have the shrinker callback fill it out appropriat

Re: [PATCH 1/3] Add a new field to struct shrinker

2016-07-28 Thread Mel Gorman
On Thu, Jul 28, 2016 at 03:49:47PM +1000, Dave Chinner wrote: > Seems you're all missing the obvious. > > Add a tracepoint for a shrinker callback that includes a "name" > field, have the shrinker callback fill it out appropriately. e.g > in the superblock shrinker: > > trace_shrinker_callb

Re: [PATCH 1/3] Add a new field to struct shrinker

2016-07-27 Thread Dave Chinner
[line wrap text at 72 columns, please] On Tue, Jul 26, 2016 at 09:40:57AM -0700, Tony Jones wrote: > On 07/20/2016 07:54 AM, Michal Hocko wrote: > >On Wed 20-07-16 20:11:09, Janani Ravichandran wrote: > >>>On Jul 11, 2016, at 8:03 PM, Michal Hocko wrote: > >>>On Mon 11-07-16 10:12:51, Rik van Ri

Re: [PATCH 1/3] Add a new field to struct shrinker

2016-07-26 Thread Tony Jones
On 07/20/2016 07:54 AM, Michal Hocko wrote: On Wed 20-07-16 20:11:09, Janani Ravichandran wrote: On Jul 11, 2016, at 8:03 PM, Michal Hocko wrote: On Mon 11-07-16 10:12:51, Rik van Riel wrote: What mechanism do you have in mind for obtaining the name, Michal? Not sure whether tracing infr

Re: [PATCH 1/3] Add a new field to struct shrinker

2016-07-23 Thread Tony Jones
On 07/23/2016 12:43 PM, Rik van Riel wrote: > Janani, > it may make sense to have the code Tony posted be part of > your patch series. Just have both of your Signed-off-by: > lines on that patch. Rik Unfortunately the previous patch doesn't work on my system, which was the point I was trying t

Re: [PATCH 1/3] Add a new field to struct shrinker

2016-07-23 Thread Rik van Riel
On Fri, 2016-07-22 at 21:05 -0700, Tony Jones wrote: > On 07/22/2016 06:27 PM, Tony Jones wrote: > > On 07/20/2016 07:54 AM, Michal Hocko wrote: > > > > > > Michal, just to make sure I understand you correctly, do you > > > > mean that we > > > > could infer the names of the shrinkers by looking a

Re: [PATCH 1/3] Add a new field to struct shrinker

2016-07-22 Thread Tony Jones
On 07/22/2016 06:27 PM, Tony Jones wrote: > On 07/20/2016 07:54 AM, Michal Hocko wrote: > >>> Michal, just to make sure I understand you correctly, do you mean that we >>> could infer the names of the shrinkers by looking at the names of their >>> callbacks? >> >> Yes, %ps can then be used for th

Re: [PATCH 1/3] Add a new field to struct shrinker

2016-07-22 Thread Tony Jones
On 07/20/2016 07:54 AM, Michal Hocko wrote: >> Michal, just to make sure I understand you correctly, do you mean that we >> could infer the names of the shrinkers by looking at the names of their >> callbacks? > > Yes, %ps can then be used for the name of the shrinker structure > (assuming it is

Re: [PATCH 1/3] Add a new field to struct shrinker

2016-07-20 Thread Michal Hocko
On Wed 20-07-16 20:11:09, Janani Ravichandran wrote: > > > On Jul 11, 2016, at 8:03 PM, Michal Hocko wrote: > > > > On Mon 11-07-16 10:12:51, Rik van Riel wrote: > >> > >> What mechanism do you have in mind for obtaining the name, > >> Michal? > > > > Not sure whether tracing infrastructure al

Re: [PATCH 1/3] Add a new field to struct shrinker

2016-07-20 Thread Janani Ravichandran
> On Jul 11, 2016, at 8:03 PM, Michal Hocko wrote: > > On Mon 11-07-16 10:12:51, Rik van Riel wrote: >> >> What mechanism do you have in mind for obtaining the name, >> Michal? > > Not sure whether tracing infrastructure allows printk like %ps. If not > then it doesn't sound too hard to add.

Re: [PATCH 1/3] Add a new field to struct shrinker

2016-07-11 Thread Rik van Riel
On Mon, 2016-07-11 at 08:37 +0200, Michal Hocko wrote: > On Sat 09-07-16 04:43:31, Janani Ravichandran wrote: > > Struct shrinker does not have a field to uniquely identify the > > shrinkers > > it represents. It would be helpful to have a new field to hold > > names of > > shrinkers. This informat

Re: [PATCH 1/3] Add a new field to struct shrinker

2016-07-11 Thread Michal Hocko
On Mon 11-07-16 10:12:51, Rik van Riel wrote: > On Mon, 2016-07-11 at 08:37 +0200, Michal Hocko wrote: > > On Sat 09-07-16 04:43:31, Janani Ravichandran wrote: > > > Struct shrinker does not have a field to uniquely identify the > > > shrinkers > > > it represents. It would be helpful to have a new

Re: [PATCH 1/3] Add a new field to struct shrinker

2016-07-10 Thread Michal Hocko
On Sat 09-07-16 04:43:31, Janani Ravichandran wrote: > Struct shrinker does not have a field to uniquely identify the shrinkers > it represents. It would be helpful to have a new field to hold names of > shrinkers. This information would be useful while analyzing their > behavior using tracepoints.

[PATCH 1/3] Add a new field to struct shrinker

2016-07-09 Thread Janani Ravichandran
Struct shrinker does not have a field to uniquely identify the shrinkers it represents. It would be helpful to have a new field to hold names of shrinkers. This information would be useful while analyzing their behavior using tracepoints. --- include/linux/shrinker.h | 1 + 1 file changed, 1 inse