Re: [PATCH 1/2] mtd: atmel_nand: use __iowrite32_copy for 32 bitcopy

2014-10-22 Thread Josh Wu
Hi, On 10/21/2014 6:35 PM, Vinod Koul wrote: On Tue, Oct 21, 2014 at 12:20:06PM +0200, Herve Codina wrote: Hi, Please don't top post I didn't go deeper in atmel_nand.c code to see other accesses but old copy use writel_relaxed which is a macro to __raw_writel((__force u32) cpu_to_le32(v),c)

Re: [PATCH 1/2] mtd: atmel_nand: use __iowrite32_copy for 32 bitcopy

2014-10-21 Thread Vinod Koul
On Tue, Oct 21, 2014 at 12:20:06PM +0200, Herve Codina wrote: > Hi, Please don't top post > > I didn't go deeper in atmel_nand.c code to see other accesses but old > copy use writel_relaxed which is a macro to __raw_writel((__force u32) > cpu_to_le32(v),c) > > __iowrite32_copy use directly __raw_

Re: [PATCH 1/2] mtd: atmel_nand: use __iowrite32_copy for 32 bitcopy

2014-10-21 Thread Herve Codina
Hi, I didn't go deeper in atmel_nand.c code to see other accesses but old copy use writel_relaxed which is a macro to __raw_writel((__force u32) cpu_to_le32(v),c) __iowrite32_copy use directly __raw_writel(*src++, dst++) So we skip cpu_to_le32. Is it ok for all system using atmel_nand ? Best re