Re: [PATCH 1/1] x86/purgatory: Change compiler flags to avoid relocation errors.

2019-09-05 Thread Andreas Smas
On Thu, Sep 5, 2019 at 11:20 AM Nick Desaulniers wrote: > > On Wed, Sep 4, 2019 at 10:34 PM Andreas Smas wrote: > > > > On Wed, Sep 4, 2019 at 3:19 PM Nick Desaulniers > > wrote: > > > Thanks for confirming the fix. While it sounds like -mcmodel=large is > > > the only necessary change, I don'

Re: [PATCH 1/1] x86/purgatory: Change compiler flags to avoid relocation errors.

2019-09-05 Thread Nick Desaulniers
On Wed, Sep 4, 2019 at 10:34 PM Andreas Smas wrote: > > On Wed, Sep 4, 2019 at 3:19 PM Nick Desaulniers > wrote: > > Thanks for confirming the fix. While it sounds like -mcmodel=large is > > the only necessary change, I don't object to -ffreestanding of > > -fno-zero-initialized-in-bss being re

Re: [PATCH 1/1] x86/purgatory: Change compiler flags to avoid relocation errors.

2019-09-05 Thread Borislav Petkov
On Thu, Sep 05, 2019 at 10:07:38AM -0500, Steve Wahl wrote: > kexec: Overflow in relocation type 11 value 0x11fffd000 That looks like R_X86_64_32S which is: "The linker must verify that the generated value for the R_X86_64_32 (R_X86_64_32S) relocation zero-extends (sign-extends) to the original 6

Re: [PATCH 1/1] x86/purgatory: Change compiler flags to avoid relocation errors.

2019-09-05 Thread Steve Wahl
On Thu, Sep 05, 2019 at 11:15:14AM +0200, Borislav Petkov wrote: > On Wed, Sep 04, 2019 at 04:45:05PM -0500, Steve Wahl wrote: > > The last change to this Makefile caused relocation errors when loading > > a kdump kernel. > > How do those relocation errors look like? kexec: Overflow in relocation

Re: [PATCH 1/1] x86/purgatory: Change compiler flags to avoid relocation errors.

2019-09-05 Thread Borislav Petkov
On Wed, Sep 04, 2019 at 04:45:05PM -0500, Steve Wahl wrote: > The last change to this Makefile caused relocation errors when loading > a kdump kernel. How do those relocation errors look like? What exactly caused those errors, the flags removal from kexec-purgatory.o? Because this is the differe

Re: [PATCH 1/1] x86/purgatory: Change compiler flags to avoid relocation errors.

2019-09-04 Thread Andreas Smas
On Wed, Sep 4, 2019 at 3:19 PM Nick Desaulniers wrote: > > + (folks recommended by ./scripts/get_maintainer.pl ) > (See also, step 7: > https://nickdesaulniers.github.io/blog/2017/05/16/submitting-your-first-patch-to-the-linux-kernel-and-responding-to-feedback/) > > On Wed, Sep 4, 2019 at 2:45 PM

Re: [PATCH 1/1] x86/purgatory: Change compiler flags to avoid relocation errors.

2019-09-04 Thread Nick Desaulniers
On Wed, Sep 4, 2019 at 5:19 PM 'Vaibhav Rustagi' via Clang Built Linux wrote: > > On Wed, Sep 4, 2019 at 3:28 PM Vaibhav Rustagi > wrote: > > > > On Wed, Sep 4, 2019 at 3:19 PM Nick Desaulniers > > wrote: > > > Vaibhav, do you still have an environment setup to quickly test this > > > again w/

Re: [PATCH 1/1] x86/purgatory: Change compiler flags to avoid relocation errors.

2019-09-04 Thread Vaibhav Rustagi
On Wed, Sep 4, 2019 at 3:28 PM Vaibhav Rustagi wrote: > > On Wed, Sep 4, 2019 at 3:19 PM Nick Desaulniers > wrote: > > > > + (folks recommended by ./scripts/get_maintainer.pl ) > > (See also, step 7: > > https://nickdesaulniers.github.io/blog/2017/05/16/submitting-your-first-patch-to-the-linux-k

Re: [PATCH 1/1] x86/purgatory: Change compiler flags to avoid relocation errors.

2019-09-04 Thread Randy Dunlap
On 9/4/19 3:18 PM, Nick Desaulniers wrote: > + (folks recommended by ./scripts/get_maintainer.pl ) > (See also, step 7: > https://nickdesaulniers.github.io/blog/2017/05/16/submitting-your-first-patch-to-the-linux-kernel-and-responding-to-feedback/) > > On Wed, Sep 4, 2019 at 2:45 PM Steve Wahl wr

Re: [PATCH 1/1] x86/purgatory: Change compiler flags to avoid relocation errors.

2019-09-04 Thread Vaibhav Rustagi
On Wed, Sep 4, 2019 at 3:19 PM Nick Desaulniers wrote: > > + (folks recommended by ./scripts/get_maintainer.pl ) > (See also, step 7: > https://nickdesaulniers.github.io/blog/2017/05/16/submitting-your-first-patch-to-the-linux-kernel-and-responding-to-feedback/) > > On Wed, Sep 4, 2019 at 2:45 PM

Re: [PATCH 1/1] x86/purgatory: Change compiler flags to avoid relocation errors.

2019-09-04 Thread Nick Desaulniers
+ (folks recommended by ./scripts/get_maintainer.pl ) (See also, step 7: https://nickdesaulniers.github.io/blog/2017/05/16/submitting-your-first-patch-to-the-linux-kernel-and-responding-to-feedback/) On Wed, Sep 4, 2019 at 2:45 PM Steve Wahl wrote: > > The last change to this Makefile caused relo

[PATCH 1/1] x86/purgatory: Change compiler flags to avoid relocation errors.

2019-09-04 Thread Steve Wahl
The last change to this Makefile caused relocation errors when loading a kdump kernel. This change restores the appropriate flags, without reverting to the former practice of resetting KBUILD_CFLAGS. Signed-off-by: Steve Wahl --- arch/x86/purgatory/Makefile | 35 +++-