On Wed, Sep 04, 2019 at 04:45:05PM -0500, Steve Wahl wrote: > The last change to this Makefile caused relocation errors when loading > a kdump kernel.
How do those relocation errors look like? What exactly caused those errors, the flags removal from kexec-purgatory.o? Because this is the difference I can see from b059f801a937 ("x86/purgatory: Use CFLAGS_REMOVE rather than reset KBUILD_CFLAGS") Or is it something else? Can we have the failure properly explained in the commit message pls? > This change restores the appropriate flags, without You don't have to say "This change" in the commit message - it is obvious which change you're talking about. Instead say: "Restore the appropriate... " Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette