Re: [PATCH 03/23] uuid: remove uuid_be defintions from the uapi header

2017-05-20 Thread Christoph Hellwig
On Fri, May 19, 2017 at 11:58:41AM +0100, David Howells wrote: > Christoph Hellwig wrote: > > > It's not a userspace ABI, so by defintion it does not break an > > existing user program. > > That's an invalid assumption. It is a de facto userspace ABI as it has been > exposed in /usr/include/lin

Re: [PATCH 03/23] uuid: remove uuid_be defintions from the uapi header

2017-05-19 Thread David Howells
Christoph Hellwig wrote: > It's not a userspace ABI, so by defintion it does not break an > existing user program. That's an invalid assumption. It is a de facto userspace ABI as it has been exposed in /usr/include/linux/uuid.h for some time. > If someone was using it they should be using uuid

Re: [PATCH 03/23] uuid: remove uuid_be defintions from the uapi header

2017-05-18 Thread Christoph Hellwig
On Thu, May 18, 2017 at 12:12:45AM -0700, Joe Perches wrote: > On Thu, 2017-05-18 at 08:26 +0200, Christoph Hellwig wrote: > > We don't use uuid_be and the UUID_BE constants in any uapi headers, so make > > them private to the kernel. > > On the assumption that no user program uses them? > Is that

Re: [PATCH 03/23] uuid: remove uuid_be defintions from the uapi header

2017-05-18 Thread Joe Perches
On Thu, 2017-05-18 at 08:26 +0200, Christoph Hellwig wrote: > We don't use uuid_be and the UUID_BE constants in any uapi headers, so make > them private to the kernel. On the assumption that no user program uses them? Is that a safe assumption? > diff --git a/include/uapi/linux/uuid.h b/include/u

[PATCH 03/23] uuid: remove uuid_be defintions from the uapi header

2017-05-17 Thread Christoph Hellwig
We don't use uuid_be and the UUID_BE constants in any uapi headers, so make them private to the kernel. Signed-off-by: Christoph Hellwig --- include/linux/uuid.h | 15 +++ include/uapi/linux/uuid.h | 16 2 files changed, 15 insertions(+), 16 deletions(-) diff -