Re: [PATCH 02/10] nohz: Kick full dynticks timer targets with an empty IPI

2014-07-29 Thread Frederic Weisbecker
On Tue, Jul 29, 2014 at 01:33:07PM +0200, Peter Zijlstra wrote: > On Mon, Jul 28, 2014 at 07:37:28PM +0200, Frederic Weisbecker wrote: > > if (tick_nohz_full_cpu(cpu)) { > > if (cpu != smp_processor_id() || > > tick_nohz_tick_stopped()) > > Not really a comment on t

Re: [PATCH 02/10] nohz: Kick full dynticks timer targets with an empty IPI

2014-07-29 Thread Peter Zijlstra
On Mon, Jul 28, 2014 at 07:37:28PM +0200, Frederic Weisbecker wrote: > if (tick_nohz_full_cpu(cpu)) { > if (cpu != smp_processor_id() || > tick_nohz_tick_stopped()) Not really a comment on this patch per-se, but why is that line broken? If I concat them its on

[PATCH 02/10] nohz: Kick full dynticks timer targets with an empty IPI

2014-07-28 Thread Frederic Weisbecker
While we enqueue a new timer on a dynticks target, we must send it an IPI so that it reschedules the next tick accordingly. Now all we need for that is to run irq_exit() on the target. Hence an empty IRQ is way enough. We don't need to run tick_nohz_full_check() and all the overhead that comes wit

Re: [PATCH 02/10] nohz: Kick full dynticks timer targets with an empty IPI

2014-07-19 Thread Frederic Weisbecker
On Sat, Jul 19, 2014 at 03:47:41PM +0200, Peter Zijlstra wrote: > On Sat, Jul 19, 2014 at 03:18:47PM +0200, Frederic Weisbecker wrote: > > On Sat, Jul 19, 2014 at 09:19:51AM +0200, Peter Zijlstra wrote: > > > On Sat, Jul 19, 2014 at 02:44:13AM +0200, Frederic Weisbecker wrote: > > > > diff --git a/

Re: [PATCH 02/10] nohz: Kick full dynticks timer targets with an empty IPI

2014-07-19 Thread Peter Zijlstra
On Sat, Jul 19, 2014 at 03:18:47PM +0200, Frederic Weisbecker wrote: > On Sat, Jul 19, 2014 at 09:19:51AM +0200, Peter Zijlstra wrote: > > On Sat, Jul 19, 2014 at 02:44:13AM +0200, Frederic Weisbecker wrote: > > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > > > index 7f3063c..f3e48b8 1

Re: [PATCH 02/10] nohz: Kick full dynticks timer targets with an empty IPI

2014-07-19 Thread Frederic Weisbecker
On Sat, Jul 19, 2014 at 09:19:51AM +0200, Peter Zijlstra wrote: > On Sat, Jul 19, 2014 at 02:44:13AM +0200, Frederic Weisbecker wrote: > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > > index 7f3063c..f3e48b8 100644 > > --- a/kernel/sched/core.c > > +++ b/kernel/sched/core.c > > @@ -693

Re: [PATCH 02/10] nohz: Kick full dynticks timer targets with an empty IPI

2014-07-19 Thread Peter Zijlstra
On Sat, Jul 19, 2014 at 02:44:13AM +0200, Frederic Weisbecker wrote: > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index 7f3063c..f3e48b8 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -693,7 +693,7 @@ static bool wake_up_full_nohz_cpu(int cpu) > if (tick_noh

[PATCH 02/10] nohz: Kick full dynticks timer targets with an empty IPI

2014-07-18 Thread Frederic Weisbecker
While we enqueue a new timer on a dynticks target, we must send it an IPI so that it reschedules the next tick accordingly. Now all we need for that is to run irq_exit() on the target. Hence an empty IRQ is way enough. We don't need to run tick_nohz_full_check() and all the overhead that comes wit