Re: [PATCH -rt] scheduling while atomic in remove_proc_entry()

2007-01-08 Thread Daniel Walker
On Mon, 2007-01-08 at 13:20 +0100, Peter Zijlstra wrote: > > Well, no. Draining after the inspect 'all' loop doesn't make sense, but > looking at 2.6.20-rc3-rt0 remove_proc_entry() looks sane. When it was inside the loop it drained every iteration . So it made more sense to put it after the loop

Re: [PATCH -rt] scheduling while atomic in remove_proc_entry()

2007-01-08 Thread Peter Zijlstra
On Fri, 2006-12-29 at 13:12 -0800, Daniel Walker wrote: > > Signed-Off-By: Daniel Walker <[EMAIL PROTECTED]> > > --- > fs/proc/generic.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletion(-) > > Index: linux-2.6.19/fs/proc/generic.c > ===

[PATCH -rt] scheduling while atomic in remove_proc_entry()

2006-12-29 Thread Daniel Walker
Found this in 2.6.20-rc2-rt3 w/ PREEMPT_RT off on x86_64, BUG: scheduling while atomic: swapper/0x0001/1, CPU#0 Call Trace: [] __sched_text_start+0xb0/0x85a [] try_to_wake_up+0x3fc/0x420 [] add_preempt_count+0x2b/0x130 [] schedule+0xe5/0x110 [] flush_cpu_workqueue+0x8d/0xd0 [] autoremov