Re: [PATCH]intel-iommu-PMEN support

2007-11-20 Thread mark gross
On Mon, Nov 19, 2007 at 04:38:02PM -0800, Andrew Morton wrote: > On Fri, 16 Nov 2007 14:39:57 -0800 > mark gross <[EMAIL PROTECTED]> wrote: > > > -#define MAX_FAULT_REASON_IDX ARRAY_SIZE(fault_reason_strings) - 1 > > +#define MAX_FAULT_REASON_IDX (ARRAY_SIZE(fault_reason_strings) - 1)

Re: [PATCH]intel-iommu-PMEN support

2007-11-19 Thread Andrew Morton
On Fri, 16 Nov 2007 14:39:57 -0800 mark gross <[EMAIL PROTECTED]> wrote: > -#define MAX_FAULT_REASON_IDX ARRAY_SIZE(fault_reason_strings) - 1 > +#define MAX_FAULT_REASON_IDX (ARRAY_SIZE(fault_reason_strings) - 1) hm. The logic in there looks screwy. static char *fault_reason_st

Re: [PATCH]intel-iommu-PMEN support

2007-11-17 Thread Muli Ben-Yehuda
On Fri, Nov 16, 2007 at 02:39:57PM -0800, mark gross wrote: > The following patch adds support for protected memory enable bits by > clearing them if they are set at startup time. Some future boot > loaders or firmware could have this bit set after it loads the > kernel, and it needs to be cleare

[PATCH]intel-iommu-PMEN support

2007-11-16 Thread mark gross
The following patch adds support for protected memory enable bits by clearing them if they are set at startup time. Some future boot loaders or firmware could have this bit set after it loads the kernel, and it needs to be cleared if DMA's are going to happen effectively. please apply --mgross