Re: [PATCH] x86: fix ref-counting bug in change_page_attr()

2007-12-17 Thread Ingo Molnar
* Jan Beulich <[EMAIL PROTECTED]> wrote: > > hm, does this patch fix any real bug seen live? (if yes then do you > > have links to it, etc?) It would be a v2.6.24 fix in theory but it > > looks too dangerous for that. So i've queued it up for v2.6.25, for > > the time being. > > I had run int

Re: [PATCH] x86: fix ref-counting bug in change_page_attr()

2007-12-17 Thread Jan Beulich
>>> Ingo Molnar <[EMAIL PROTECTED]> 17.12.07 14:28 >>> > >* Jan Beulich <[EMAIL PROTECTED]> wrote: > >> When either calling change_page_attr() with the default attributes >> pages in the direct mapping have and a page's attributes already were >> set to the default or when changing the attributes

Re: [PATCH] x86: fix ref-counting bug in change_page_attr()

2007-12-17 Thread Ingo Molnar
* Jan Beulich <[EMAIL PROTECTED]> wrote: > When either calling change_page_attr() with the default attributes > pages in the direct mapping have and a page's attributes already were > set to the default or when changing the attributes from one > non-default value to another, the reference coun

Re: [PATCH] x86: fix ref-counting bug in change_page_attr()

2007-12-14 Thread Jan Beulich
>>> Jeremy Fitzhardinge <[EMAIL PROTECTED]> 14.12.07 08:12 >>> >Jan Beulich wrote: >> When either calling change_page_attr() with the default attributes >> pages in the direct mapping have and a page's attributes already were >> set to the default or when changing the attributes from one non-defaul

Re: [PATCH] x86: fix ref-counting bug in change_page_attr()

2007-12-13 Thread Jeremy Fitzhardinge
Jan Beulich wrote: > When either calling change_page_attr() with the default attributes > pages in the direct mapping have and a page's attributes already were > set to the default or when changing the attributes from one non-default > value to another, the reference counting broke, leading to eith

[PATCH] x86: fix ref-counting bug in change_page_attr()

2007-12-13 Thread Jan Beulich
When either calling change_page_attr() with the default attributes pages in the direct mapping have and a page's attributes already were set to the default or when changing the attributes from one non-default value to another, the reference counting broke, leading to either premature restoration of