Re: [PATCH] x86/raid6: correctly check for assembler capabilities

2015-06-16 Thread Paul Bolle
On Tue, 2015-06-16 at 13:42 -0700, H. Peter Anvin wrote: > Yes, these would be generated, not user input. I think someone (Jiri Kosina?) proposed shelling out to set Kconfig values. I don't think any patches were ever submitted. But I guess something along those lines would be needed to adopt the

Re: [PATCH] x86/raid6: correctly check for assembler capabilities

2015-06-16 Thread H. Peter Anvin
On 06/16/2015 01:37 PM, Paul Bolle wrote: > > I have no idea what AS_AVX2 means, sorry. So what would it mean if > someone has a .config with > CONFIG_AS_AVX2=foo > > Ie, what would happen if someone using a toolchain for which that would > not be possible tries to build a kernel with that sy

Re: [PATCH] x86/raid6: correctly check for assembler capabilities

2015-06-16 Thread Paul Bolle
On Tue, 2015-06-16 at 13:05 -0700, H. Peter Anvin wrote: > So this related to the CONFIG_AS_ symbols for assembly. We really would > like to do things like actually adding dependencies on assembler or > compiler support into Kconfig proper, rather than having two independent > mechanisms. That wa

Re: [PATCH] x86/raid6: correctly check for assembler capabilities

2015-06-16 Thread H. Peter Anvin
On 06/16/2015 12:56 PM, Paul Bolle wrote: > On Tue, 2015-06-16 at 12:46 -0700, H. Peter Anvin wrote: >> There is a hope/intent that eventually the config system will be able to >> incorporate toolchain dependencies for a bunch of reasons. > > This restarts a four months old thread with a one sente

Re: [PATCH] x86/raid6: correctly check for assembler capabilities

2015-06-16 Thread Paul Bolle
On Tue, 2015-06-16 at 12:46 -0700, H. Peter Anvin wrote: > There is a hope/intent that eventually the config system will be able to > incorporate toolchain dependencies for a bunch of reasons. This restarts a four months old thread with a one sentence remark. So could you please elaborate, because

Re: [PATCH] x86/raid6: correctly check for assembler capabilities

2015-06-16 Thread H. Peter Anvin
On 02/03/2015 01:03 PM, Paul Bolle wrote: > On Wed, 2015-02-04 at 07:50 +1100, NeilBrown wrote: >> Actually the prefix of this macro is "CONFIG_AS_", not "CONFIG_" :-) >> CONFIG_AS_ is reserved for assembly magic, and is never used by the the >> kconfig system. >> >> (Well. I might have made bi

Re: [PATCH] x86/raid6: correctly check for assembler capabilities

2015-02-03 Thread Jan Beulich
>>> On 03.02.15 at 22:03, wrote: > On Wed, 2015-02-04 at 07:50 +1100, NeilBrown wrote: >> Actually the prefix of this macro is "CONFIG_AS_", not "CONFIG_" :-) >> CONFIG_AS_ is reserved for assembly magic, and is never used by the the >> kconfig system. >> >> (Well. I might have made bits of t

Re: [PATCH] x86/raid6: correctly check for assembler capabilities

2015-02-03 Thread Valentin Rothberg
On Tue, Feb 3, 2015 at 10:09 PM, NeilBrown wrote: > On Tue, 03 Feb 2015 22:03:35 +0100 Paul Bolle wrote: > >> On Wed, 2015-02-04 at 07:50 +1100, NeilBrown wrote: >> > Actually the prefix of this macro is "CONFIG_AS_", not "CONFIG_" :-) >> > CONFIG_AS_ is reserved for assembly magic, and is never

Re: [PATCH] x86/raid6: correctly check for assembler capabilities

2015-02-03 Thread NeilBrown
On Tue, 03 Feb 2015 22:03:35 +0100 Paul Bolle wrote: > On Wed, 2015-02-04 at 07:50 +1100, NeilBrown wrote: > > Actually the prefix of this macro is "CONFIG_AS_", not "CONFIG_" :-) > > CONFIG_AS_ is reserved for assembly magic, and is never used by the the > > kconfig system. > > > > (Well. I

Re: [PATCH] x86/raid6: correctly check for assembler capabilities

2015-02-03 Thread Paul Bolle
On Wed, 2015-02-04 at 07:50 +1100, NeilBrown wrote: > Actually the prefix of this macro is "CONFIG_AS_", not "CONFIG_" :-) > CONFIG_AS_ is reserved for assembly magic, and is never used by the the > kconfig system. > > (Well. I might have made bits of that up, but "git grep 'config AS_'" > doe

Re: [PATCH] x86/raid6: correctly check for assembler capabilities

2015-02-03 Thread NeilBrown
On Tue, 03 Feb 2015 21:31:30 +0100 Paul Bolle wrote: > On Fri, 2015-01-23 at 08:29 +, Jan Beulich wrote: > > Just like for AVX2 (which simply needs an #if -> #ifdef conversion), > > SSSE3 assembler support should be checked for before using it. > > > > Signed-off-by: Jan Beulich > > Cc: Jim

Re: [PATCH] x86/raid6: correctly check for assembler capabilities

2015-02-03 Thread Paul Bolle
On Fri, 2015-01-23 at 08:29 +, Jan Beulich wrote: > Just like for AVX2 (which simply needs an #if -> #ifdef conversion), > SSSE3 assembler support should be checked for before using it. > > Signed-off-by: Jan Beulich > Cc: Jim Kukunas > Cc: Neil Brown This patch became commit be46ac86a81b

Re: [PATCH] x86/raid6: correctly check for assembler capabilities

2015-01-27 Thread NeilBrown
On Fri, 23 Jan 2015 17:16:59 +0100 (CET) Thomas Gleixner wrote: > On Fri, 23 Jan 2015, Jan Beulich wrote: > > > Just like for AVX2 (which simply needs an #if -> #ifdef conversion), > > SSSE3 assembler support should be checked for before using it. > > > > Signed-off-by: Jan Beulich > > Cc: Jim

Re: [PATCH] x86/raid6: correctly check for assembler capabilities

2015-01-23 Thread Thomas Gleixner
On Fri, 23 Jan 2015, Jan Beulich wrote: > Just like for AVX2 (which simply needs an #if -> #ifdef conversion), > SSSE3 assembler support should be checked for before using it. > > Signed-off-by: Jan Beulich > Cc: Jim Kukunas > Cc: Neil Brown > --- > arch/x86/Makefile |1 + For the x

[PATCH] x86/raid6: correctly check for assembler capabilities

2015-01-23 Thread Jan Beulich
Just like for AVX2 (which simply needs an #if -> #ifdef conversion), SSSE3 assembler support should be checked for before using it. Signed-off-by: Jan Beulich Cc: Jim Kukunas Cc: Neil Brown --- arch/x86/Makefile |1 + lib/raid6/algos.c |2 +- lib/raid6/recov_avx2.c |2