Re: [PATCH] virtio-input: reset device during remove

2015-08-05 Thread Jason Wang
On 08/05/2015 03:56 PM, Michael S. Tsirkin wrote: > On Wed, Aug 05, 2015 at 03:20:18PM +0800, Jason Wang wrote: >> > Spec requires a device reset during cleanup, so do it and avoid warn >> > in virtio core. >> > >> > Signed-off-by: Jason Wang > OK but now that I look at this driver, that's not

Re: [PATCH] virtio-input: reset device during remove

2015-08-05 Thread Michael S. Tsirkin
On Wed, Aug 05, 2015 at 03:20:18PM +0800, Jason Wang wrote: > Spec requires a device reset during cleanup, so do it and avoid warn > in virtio core. > > Signed-off-by: Jason Wang OK but now that I look at this driver, that's not enough. Need to also detach and free unused buffers, otherwise we

[PATCH] virtio-input: reset device during remove

2015-08-05 Thread Jason Wang
Spec requires a device reset during cleanup, so do it and avoid warn in virtio core. Signed-off-by: Jason Wang --- drivers/virtio/virtio_input.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/virtio/virtio_input.c b/drivers/virtio/virtio_input.c index 60e2a16..6222f9b 100644 --- a/d