On Wed, Aug 05, 2015 at 03:20:18PM +0800, Jason Wang wrote: > Spec requires a device reset during cleanup, so do it and avoid warn > in virtio core. > > Signed-off-by: Jason Wang <jasow...@redhat.com>
OK but now that I look at this driver, that's not enough. Need to also detach and free unused buffers, otherwise we leak memory in evt and sts queues. > --- > drivers/virtio/virtio_input.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/virtio/virtio_input.c b/drivers/virtio/virtio_input.c > index 60e2a16..6222f9b 100644 > --- a/drivers/virtio/virtio_input.c > +++ b/drivers/virtio/virtio_input.c > @@ -320,6 +320,7 @@ static void virtinput_remove(struct virtio_device *vdev) > spin_unlock_irqrestore(&vi->lock, flags); > > input_unregister_device(vi->idev); > + vdev->config->reset(vdev); > vdev->config->del_vqs(vdev); > kfree(vi); > } > -- > 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
