Re: [PATCH] virtio: console: Make resizing compliant with virtio spec

2025-04-05 Thread Maximilian Immanuel Brandtner
On Tue, 2025-03-18 at 15:25 +0100, Amit Shah wrote: > On Tue, 2025-03-18 at 11:07 +0100, Maximilian Immanuel Brandtner > wrote: > > On Mon, 2025-03-03 at 12:54 +0100, Amit Shah wrote: > > > On Tue, 2025-02-25 at 10:21 +0100, Maximilian Immanuel Brandtner > > > wrote: > > > > According to the virtio

Re: [PATCH] virtio: console: Make resizing compliant with virtio spec

2025-04-04 Thread Michael S. Tsirkin
On Wed, Mar 19, 2025 at 06:13:08PM +0100, Halil Pasic wrote: > On Wed, 19 Mar 2025 11:00:06 -0400 > "Michael S. Tsirkin" wrote: > > > > > I was mistaken in my earlier reply - I had missed this > > > > virtio_console_resize definition in the spec.  So indeed there's a > > > > discrepancy in Linux

Re: [PATCH] virtio: console: Make resizing compliant with virtio spec

2025-03-28 Thread Halil Pasic
On Thu, 20 Mar 2025 15:09:57 +0100 Halil Pasic wrote: > > I already implemented it in my patch v2 (just waiting for Amit to > > confirm the new commit message). But if you want to split it you can > > create a seperate patch for it as well (I don't really mind either > > way). > > Your v2 has

Re: [PATCH] virtio: console: Make resizing compliant with virtio spec

2025-03-20 Thread Maximilian Immanuel Brandtner
On Thu, 2025-03-20 at 15:19 +0100, Halil Pasic wrote: > On Thu, 20 Mar 2025 15:09:57 +0100 > Halil Pasic wrote: > > > > I already implemented it in my patch v2 (just waiting for Amit to > > > confirm the new commit message). But if you want to split it you > > > can > > > create a seperate patch

Re: [PATCH] virtio: console: Make resizing compliant with virtio spec

2025-03-20 Thread Halil Pasic
On Thu, 20 Mar 2025 12:53:43 +0100 Maximilian Immanuel Brandtner wrote: > On Thu, 2025-03-20 at 11:41 +0100, Halil Pasic wrote: > > On Thu, 20 Mar 2025 08:12:23 +0100 > > Maximilian Immanuel Brandtner wrote: > > > > > > Another thing I noticed during looking at this. AFAICT Linux does > > > >

Re: [PATCH] virtio: console: Make resizing compliant with virtio spec

2025-03-20 Thread Maximilian Immanuel Brandtner
On Thu, 2025-03-20 at 11:41 +0100, Halil Pasic wrote: > On Thu, 20 Mar 2025 08:12:23 +0100 > Maximilian Immanuel Brandtner wrote: > > > > Another thing I noticed during looking at this. AFAICT Linux does > > > not > > > seem to handle endiannes here. And AFAIU the message is supposed > > > to > >

Re: [PATCH] virtio: console: Make resizing compliant with virtio spec

2025-03-20 Thread Halil Pasic
On Thu, 20 Mar 2025 08:12:23 +0100 Maximilian Immanuel Brandtner wrote: > > Another thing I noticed during looking at this. AFAICT Linux does not > > seem to handle endiannes here. And AFAIU the message is supposed to > > hold > > le16 that is little endian u16! Maximilian, is this in your opinio

Re: [PATCH] virtio: console: Make resizing compliant with virtio spec

2025-03-20 Thread Maximilian Immanuel Brandtner
On Tue, 2025-03-18 at 15:25 +0100, Amit Shah wrote: > On Tue, 2025-03-18 at 11:07 +0100, Maximilian Immanuel Brandtner > wrote: > > On Mon, 2025-03-03 at 12:54 +0100, Amit Shah wrote: > > > On Tue, 2025-02-25 at 10:21 +0100, Maximilian Immanuel Brandtner > > > wrote: > > > > According to the virtio

Re: [PATCH] virtio: console: Make resizing compliant with virtio spec

2025-03-20 Thread Maximilian Immanuel Brandtner
On Wed, 2025-03-19 at 18:13 +0100, Halil Pasic wrote: > On Wed, 19 Mar 2025 11:00:06 -0400 > "Michael S. Tsirkin" wrote: > > > > > I was mistaken in my earlier reply - I had missed this > > > > virtio_console_resize definition in the spec.  So indeed > > > > there's a > > > > discrepancy in Linux

Re: [PATCH] virtio: console: Make resizing compliant with virtio spec

2025-03-19 Thread Michael S. Tsirkin
On Wed, Mar 19, 2025 at 02:00:44PM +0100, Maximilian Immanuel Brandtner wrote: > On Tue, 2025-03-18 at 15:25 +0100, Amit Shah wrote: > > On Tue, 2025-03-18 at 11:07 +0100, Maximilian Immanuel Brandtner > > wrote: > > > On Mon, 2025-03-03 at 12:54 +0100, Amit Shah wrote: > > > > On Tue, 2025-02-25 a

Re: [PATCH] virtio: console: Make resizing compliant with virtio spec

2025-03-19 Thread Halil Pasic
On Wed, 19 Mar 2025 11:00:06 -0400 "Michael S. Tsirkin" wrote: > > > I was mistaken in my earlier reply - I had missed this > > > virtio_console_resize definition in the spec.  So indeed there's a > > > discrepancy in Linux kernel and the spec's ordering for the control > > > message. > > > > >

Re: [PATCH] virtio: console: Make resizing compliant with virtio spec

2025-03-19 Thread Maximilian Immanuel Brandtner
On Tue, 2025-03-18 at 15:25 +0100, Amit Shah wrote: > On Tue, 2025-03-18 at 11:07 +0100, Maximilian Immanuel Brandtner > wrote: > > On Mon, 2025-03-03 at 12:54 +0100, Amit Shah wrote: > > > On Tue, 2025-02-25 at 10:21 +0100, Maximilian Immanuel Brandtner > > > wrote: > > > > According to the virtio

Re: [PATCH] virtio: console: Make resizing compliant with virtio spec

2025-03-19 Thread Amit Shah
On Wed, 2025-03-19 at 09:54 +0100, Maximilian Immanuel Brandtner wrote: > On Tue, 2025-03-18 at 15:25 +0100, Amit Shah wrote: > > On Tue, 2025-03-18 at 11:07 +0100, Maximilian Immanuel Brandtner > > wrote: > > > On Mon, 2025-03-03 at 12:54 +0100, Amit Shah wrote: > > > > On Tue, 2025-02-25 at 10:21

Re: [PATCH] virtio: console: Make resizing compliant with virtio spec

2025-03-19 Thread Amit Shah
On Tue, 2025-03-18 at 11:07 +0100, Maximilian Immanuel Brandtner wrote: > On Mon, 2025-03-03 at 12:54 +0100, Amit Shah wrote: > > On Tue, 2025-02-25 at 10:21 +0100, Maximilian Immanuel Brandtner > > wrote: > > > According to the virtio spec[0] the virtio console resize struct > > > defines > > > co

Re: [PATCH] virtio: console: Make resizing compliant with virtio spec

2025-03-18 Thread Maximilian Immanuel Brandtner
On Mon, 2025-03-03 at 12:54 +0100, Amit Shah wrote: > On Tue, 2025-02-25 at 10:21 +0100, Maximilian Immanuel Brandtner > wrote: > > According to the virtio spec[0] the virtio console resize struct > > defines > > cols before rows. In the kernel implementation it is the other way > > around > > resu

Re: [PATCH] virtio: console: Make resizing compliant with virtio spec

2025-03-18 Thread Amit Shah
On Mon, 2025-03-10 at 14:04 +0100, Maximilian Immanuel Brandtner wrote: [...] > Just to make sure that everyone here is one the same page there is > indeed a difference between the ordering of the control resize > message > and the kernel implementation; however as this bug has been around > for

Re: [PATCH] virtio: console: Make resizing compliant with virtio spec

2025-03-10 Thread Maximilian Immanuel Brandtner
On Wed, 2025-03-05 at 13:15 +0100, Niklas Schnelle wrote: > On Wed, 2025-03-05 at 13:13 +0100, Niklas Schnelle wrote: > > On Wed, 2025-03-05 at 10:53 +0100, Maximilian Immanuel Brandtner > > wrote: > > > On Mon, 2025-03-03 at 12:54 +0100, Amit Shah wrote: > > > > On Tue, 2025-02-25 at 10:21 +0100,

Re: [PATCH] virtio: console: Make resizing compliant with virtio spec

2025-03-05 Thread Maximilian Immanuel Brandtner
On Wed, 2025-03-05 at 13:15 +0100, Niklas Schnelle wrote: > On Wed, 2025-03-05 at 13:13 +0100, Niklas Schnelle wrote: > > On Wed, 2025-03-05 at 10:53 +0100, Maximilian Immanuel Brandtner > > wrote: > > > On Mon, 2025-03-03 at 12:54 +0100, Amit Shah wrote: > > > > On Tue, 2025-02-25 at 10:21 +0100,

Re: [PATCH] virtio: console: Make resizing compliant with virtio spec

2025-03-05 Thread Niklas Schnelle
On Wed, 2025-03-05 at 13:13 +0100, Niklas Schnelle wrote: > On Wed, 2025-03-05 at 10:53 +0100, Maximilian Immanuel Brandtner wrote: > > On Mon, 2025-03-03 at 12:54 +0100, Amit Shah wrote: > > > On Tue, 2025-02-25 at 10:21 +0100, Maximilian Immanuel Brandtner > > > wrote: > > > > According to the vi

Re: [PATCH] virtio: console: Make resizing compliant with virtio spec

2025-03-05 Thread Niklas Schnelle
On Wed, 2025-03-05 at 10:53 +0100, Maximilian Immanuel Brandtner wrote: > On Mon, 2025-03-03 at 12:54 +0100, Amit Shah wrote: > > On Tue, 2025-02-25 at 10:21 +0100, Maximilian Immanuel Brandtner > > wrote: > > > According to the virtio spec[0] the virtio console resize struct > > > defines > > > co

Re: [PATCH] virtio: console: Make resizing compliant with virtio spec

2025-03-05 Thread Maximilian Immanuel Brandtner
On Mon, 2025-03-03 at 12:54 +0100, Amit Shah wrote: > On Tue, 2025-02-25 at 10:21 +0100, Maximilian Immanuel Brandtner > wrote: > > According to the virtio spec[0] the virtio console resize struct > > defines > > cols before rows. In the kernel implementation it is the other way > > around > > resu

Re: [PATCH] virtio: console: Make resizing compliant with virtio spec

2025-03-03 Thread Amit Shah
On Tue, 2025-02-25 at 10:21 +0100, Maximilian Immanuel Brandtner wrote: > According to the virtio spec[0] the virtio console resize struct > defines > cols before rows. In the kernel implementation it is the other way > around > resulting in the two properties being switched. Not true, see below.

[PATCH] virtio: console: Make resizing compliant with virtio spec

2025-02-25 Thread Maximilian Immanuel Brandtner
According to the virtio spec[0] the virtio console resize struct defines cols before rows. In the kernel implementation it is the other way around resulting in the two properties being switched. While QEMU doesn't currently support resizing consoles, TinyEMU does[1](and they implement resizing acco