Re: [PATCH] use callbacks to access UART_DLL/UART_DLM

2015-12-17 Thread Mason
On 17/12/2015 19:09, Måns Rullgård wrote: > It could well be that your patch results in a clearer final version, but > the diff is harder to parse when unchanged lines have moved around. When all other things are equal, is the priority 1) making the patch as clear as possible? 2) making the resu

Re: [PATCH] use callbacks to access UART_DLL/UART_DLM

2015-12-17 Thread Måns Rullgård
Sebastian Frias writes: >>>old_lcr = serial_in(p, UART_LCR); >>> -serial_out(p, UART_LCR, UART_LCR_CONF_MODE_A); >>> - >>> -old_dll = serial_in(p, UART_DLL); >>> -old_dlm = serial_in(p, UART_DLM); >>> >>> -serial_out(p, UART_DLL, 0); >>> -serial_out(p, UART_DLM, 0); >>

Re: [PATCH] use callbacks to access UART_DLL/UART_DLM

2015-12-17 Thread Sebastian Frias
On 12/17/2015 05:02 PM, Måns Rullgård wrote: Sebastian Frias writes: --- resending as plain-text --- drivers/tty/serial/8250/8250_core.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8

[PATCH] use callbacks to access UART_DLL/UART_DLM

2015-12-17 Thread Sebastian Frias
--- resending as plain-text --- drivers/tty/serial/8250/8250_core.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c index 2c46a21..9ca863c 100644 --- a/drivers/tty/serial/8250/8250

Re: [PATCH] use callbacks to access UART_DLL/UART_DLM

2015-12-17 Thread Måns Rullgård
Sebastian Frias writes: > --- > resending as plain-text > --- > drivers/tty/serial/8250/8250_core.c | 17 +++-- > 1 file changed, 7 insertions(+), 10 deletions(-) > > diff --git a/drivers/tty/serial/8250/8250_core.c > b/drivers/tty/serial/8250/8250_core.c > index 2c46a21..9ca863