Sebastian Frias <s...@laposte.net> writes: >>> old_lcr = serial_in(p, UART_LCR); >>> - serial_out(p, UART_LCR, UART_LCR_CONF_MODE_A); >>> - >>> - old_dll = serial_in(p, UART_DLL); >>> - old_dlm = serial_in(p, UART_DLM); >>> >>> - serial_out(p, UART_DLL, 0); >>> - serial_out(p, UART_DLM, 0); >>> + serial_out(p, UART_LCR, UART_LCR_CONF_MODE_A); >>> >>> - id = serial_in(p, UART_DLL) | serial_in(p, UART_DLM) << 8; >>> + old_dl = serial_dl_read(p); >>> + serial_dl_write(p, 0); >>> + id = serial_dl_read(p); >>> + serial_dl_write(p, old_dl); >>> >>> - serial_out(p, UART_DLL, old_dll); >>> - serial_out(p, UART_DLM, old_dlm); >>> serial_out(p, UART_LCR, old_lcr); >>> >>> return id; >>> -- >> >> If you left the blank lines alone, the patch would end up much easier to >> understand. In this diff, some of the lines listed as added or removed >> have actually not changed, and that's not immediately obvious. >> > > The old code had some blank lines, which I suppose were there for clarity. > I attempted to follow the same idea. > But I don't mind changing the code as you wish.
It could well be that your patch results in a clearer final version, but the diff is harder to parse when unchanged lines have moved around. -- Måns Rullgård -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
